Add nostate prefetch browser tests
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/215218973a66366ffa99d1bcfddbb4cd8113e089 commit 215218973a66366ffa99d1bcfddbb4cd8113e089 Author: mattcary <mattcary@chromium.org> Date: Thu Sep 08 07:25:59 2016 NoState Prefetch: Refactor prerender_browsertests.cc This refactors prerender_browsertests in preparation for adding nostate prefetch tests. The idea is to make the nostate prefetch tests independent from the current prerender tests in order to make deprecation & removal of prerender as easy as possible. prerender_test_utils.* contain code extracted from prerender_browsertest.cc with only syntatic changes. See crrev.com/2304953002 for nostate prefetch browser tests. This does not change any functionality. BUG= 643652 Review-Url: https://codereview.chromium.org/2309443002 Cr-Commit-Position: refs/heads/master@{#417220} [modify] https://crrev.com/215218973a66366ffa99d1bcfddbb4cd8113e089/chrome/browser/prerender/prerender_browsertest.cc [modify] https://crrev.com/215218973a66366ffa99d1bcfddbb4cd8113e089/chrome/browser/prerender/prerender_manager.h [add] https://crrev.com/215218973a66366ffa99d1bcfddbb4cd8113e089/chrome/browser/prerender/prerender_test_utils.cc [add] https://crrev.com/215218973a66366ffa99d1bcfddbb4cd8113e089/chrome/browser/prerender/prerender_test_utils.h [modify] https://crrev.com/215218973a66366ffa99d1bcfddbb4cd8113e089/chrome/test/BUILD.gn
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fb7f2b60cd9e83105477a441870873fd7f0df1a0 commit fb7f2b60cd9e83105477a441870873fd7f0df1a0 Author: mattcary <mattcary@chromium.org> Date: Mon Oct 17 08:34:35 2016 NoState Prefetch: nostate prefetch browser tests. This adds browser tests for nostate prefetch. It relies on the refactoring done in crrev.com/2309443002. BUG= 643652 Review-Url: https://codereview.chromium.org/2304953002 Cr-Commit-Position: refs/heads/master@{#425635} [modify] https://crrev.com/fb7f2b60cd9e83105477a441870873fd7f0df1a0/chrome/browser/prerender/prerender_browsertest.cc [modify] https://crrev.com/fb7f2b60cd9e83105477a441870873fd7f0df1a0/chrome/browser/prerender/prerender_contents.cc [modify] https://crrev.com/fb7f2b60cd9e83105477a441870873fd7f0df1a0/chrome/browser/prerender/prerender_contents.h [modify] https://crrev.com/fb7f2b60cd9e83105477a441870873fd7f0df1a0/chrome/browser/prerender/prerender_manager.cc [modify] https://crrev.com/fb7f2b60cd9e83105477a441870873fd7f0df1a0/chrome/browser/prerender/prerender_manager.h [add] https://crrev.com/fb7f2b60cd9e83105477a441870873fd7f0df1a0/chrome/browser/prerender/prerender_nostate_prefetch_browsertest.cc [modify] https://crrev.com/fb7f2b60cd9e83105477a441870873fd7f0df1a0/chrome/browser/prerender/prerender_test_utils.cc [modify] https://crrev.com/fb7f2b60cd9e83105477a441870873fd7f0df1a0/chrome/browser/prerender/prerender_test_utils.h [modify] https://crrev.com/fb7f2b60cd9e83105477a441870873fd7f0df1a0/chrome/browser/prerender/prerender_unittest.cc [modify] https://crrev.com/fb7f2b60cd9e83105477a441870873fd7f0df1a0/chrome/test/BUILD.gn [add] https://crrev.com/fb7f2b60cd9e83105477a441870873fd7f0df1a0/chrome/test/data/prerender/prefetch.js [add] https://crrev.com/fb7f2b60cd9e83105477a441870873fd7f0df1a0/chrome/test/data/prerender/prefetch2.js [add] https://crrev.com/fb7f2b60cd9e83105477a441870873fd7f0df1a0/chrome/test/data/prerender/prefetch_image.html [add] https://crrev.com/fb7f2b60cd9e83105477a441870873fd7f0df1a0/chrome/test/data/prerender/prefetch_loader.html [add] https://crrev.com/fb7f2b60cd9e83105477a441870873fd7f0df1a0/chrome/test/data/prerender/prefetch_loop.html [add] https://crrev.com/fb7f2b60cd9e83105477a441870873fd7f0df1a0/chrome/test/data/prerender/prefetch_page.html [add] https://crrev.com/fb7f2b60cd9e83105477a441870873fd7f0df1a0/chrome/test/data/prerender/prefetch_page2.html [add] https://crrev.com/fb7f2b60cd9e83105477a441870873fd7f0df1a0/chrome/test/data/prerender/prefetch_subresource_redirect.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5b870b676ffb62117e37fa64ee4a76b8182e099b commit 5b870b676ffb62117e37fa64ee4a76b8182e099b Author: mattcary <mattcary@chromium.org> Date: Mon Oct 17 12:58:02 2016 NoState Prefetch: CSP test We currently skip prefetching entirely if there is a CSP meta tag. This is probably not something we want to do long term; this test will document that and make it clear when we've changed it. BUG= 643652 Review-Url: https://codereview.chromium.org/2350813003 Cr-Commit-Position: refs/heads/master@{#425666} [modify] https://crrev.com/5b870b676ffb62117e37fa64ee4a76b8182e099b/chrome/browser/prerender/prerender_nostate_prefetch_browsertest.cc [modify] https://crrev.com/5b870b676ffb62117e37fa64ee4a76b8182e099b/chrome/browser/prerender/prerender_test_utils.h [add] https://crrev.com/5b870b676ffb62117e37fa64ee4a76b8182e099b/chrome/test/data/prerender/prefetch_meta_csp.html [add] https://crrev.com/5b870b676ffb62117e37fa64ee4a76b8182e099b/chrome/test/data/prerender/prefetch_response_csp.html [add] https://crrev.com/5b870b676ffb62117e37fa64ee4a76b8182e099b/chrome/test/data/prerender/prefetch_response_csp.html.mock-http-headers
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0b1e4e811cca307ef42d014937ee604161ce637e commit 0b1e4e811cca307ef42d014937ee604161ce637e Author: pasko <pasko@chromium.org> Date: Thu Oct 20 12:55:56 2016 [NoStatePrefetch] Remove JS injection in tests With upcoming changes the renderer that is used for prefetch will exit early before tests have a chance to execute javascript there. Fortunately, there is another way to check whether javascript is executed: requesting a resource from an inline script in a blocking manner. This is simpler than changing the lifetime of the renderer specifically for tests. NoStatePrefetchBrowserTest.CheckJavascript would still be able to run with the new renderer lifetime, but I decided to still remove it because it is testing mechanisms that are not used any more. BUG= 643652 Review-Url: https://chromiumcodereview.appspot.com/2438593002 Cr-Commit-Position: refs/heads/master@{#426460} [modify] https://crrev.com/0b1e4e811cca307ef42d014937ee604161ce637e/chrome/browser/prerender/prerender_nostate_prefetch_browsertest.cc [modify] https://crrev.com/0b1e4e811cca307ef42d014937ee604161ce637e/chrome/test/data/prerender/prefetch.js [modify] https://crrev.com/0b1e4e811cca307ef42d014937ee604161ce637e/chrome/test/data/prerender/prefetch_page.html [modify] https://crrev.com/0b1e4e811cca307ef42d014937ee604161ce637e/chrome/test/data/prerender/prefetch_page2.html [modify] https://crrev.com/0b1e4e811cca307ef42d014937ee604161ce637e/chrome/test/data/prerender/prefetch_response_csp.html
Comment 1 by bugdroid1@chromium.org
, Sep 8 2016