New issue
Advanced search Search tips

Issue 643651 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Spinning Chrome logo on About page does not work

Reported by smswes...@gmail.com, Sep 2 2016

Issue description

As of Chrome stable branch 53.0.2785.89 m, the spinning chrome logo on the new About page at chrome://settings/help does not work as intended.

To reproduce:
1. Go to chrome://settings/help
2. Click (or tap) on the Chrome logo.
3. Nothing happens.

 
What will I do without this beautiful feature?! :(
Working properly here. Clicking or tapping the Chrome logo in the About Chrome page causes the Chrome logo to spin. Do you have any extensions?
Yes, but the spinning logo worked fine for me with the old About page.
The spinning Chrome logo is working as intended here. One of your extensions may have updated when Chrome updated. Can you try disabling all of your extensions, restarting Chrome, and retesting?
Labels: -Pri-2 Hotlist-MD-Settings-About Pri-1
Owner: dbeam@chromium.org
Status: Assigned (was: Unconfirmed)
@dbeam, this should be your top priority ;-)
You're able to reproduce the issue?
I disabled all extensions. Still won't work at the chrome://settings/about page in Chrome 53.

Comment 8 by dbeam@chromium.org, Sep 7 2016

Cc: alancutter@chromium.org

Comment 9 by dbeam@chromium.org, Sep 7 2016

I think there are 2 issues here:

1) the new page (chrome://md-settings) doesn't have the spin[1]
2) the old page's animation mechanism is potentially broken for some users

I'm using this bug for 1), but we should also look into 2).

smswessem@: do you have --enable-experimental-web-platform-features turned on, out of curiosity?

[1] will soon: https://codereview.chromium.org/2324523002/
I do not have --enable-experimental-web-platform-features on.
chrome://settings/help doesn't go to the about page for me, it just goes to settings. Maybe this means OP has the new settings page enabled?
@11 Maybe try chrome://chrome or chrome://help?

Comment 13 Deleted

smswessem@: can you post a screenshot?
Project Member

Comment 15 by bugdroid1@chromium.org, Sep 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/05fc08750bd6c061013232ed4879b4e73f47e94b

commit 05fc08750bd6c061013232ed4879b4e73f47e94b
Author: dbeam <dbeam@chromium.org>
Date: Thu Sep 08 01:37:33 2016

MD Settings: restore super important about page functionality

R=hcarmona@chromium.org
BUG= 643651 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2324523002
Cr-Commit-Position: refs/heads/master@{#417153}

[modify] https://crrev.com/05fc08750bd6c061013232ed4879b4e73f47e94b/chrome/browser/resources/settings/about_page/about_page.html
[modify] https://crrev.com/05fc08750bd6c061013232ed4879b4e73f47e94b/chrome/browser/resources/settings/about_page/about_page.js

Sure, dbeam.
Oh, and thanks so much, Chromium team! I couldn't survive without this *very* useful feature! XD
Screenshot (3).png
81.3 KB View Download
Project Member

Comment 17 by bugdroid1@chromium.org, Sep 8 2016

Labels: merge-merged-2854
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/05fc08750bd6c061013232ed4879b4e73f47e94b

commit 05fc08750bd6c061013232ed4879b4e73f47e94b
Author: dbeam <dbeam@chromium.org>
Date: Thu Sep 08 01:37:33 2016

MD Settings: restore super important about page functionality

R=hcarmona@chromium.org
BUG= 643651 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2324523002
Cr-Commit-Position: refs/heads/master@{#417153}

[modify] https://crrev.com/05fc08750bd6c061013232ed4879b4e73f47e94b/chrome/browser/resources/settings/about_page/about_page.html
[modify] https://crrev.com/05fc08750bd6c061013232ed4879b4e73f47e94b/chrome/browser/resources/settings/about_page/about_page.js

Status: Fixed (was: Assigned)
yeah, you do have the Material Design Settings page (a new, experimental version)

I assume you flipped --enable-md-settings or --enable-features=MaterialDesignSettings somehow to see this new version.

for what it's worth: this critical functionality ;) is now re-implemented in the new about page as well.  it'll be showing up eventually (on canary tomorrow) in a Chrome near you.

Comment 19 Deleted

Sign in to add a comment