New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 643649 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
gone, assign your bugs elsewhere :)
Closed: Oct 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 660604
issue 660608



Sign in to add a comment

Enable system_health_smoke_test on Nexus5x but not Nexus5

Project Member Reported by nedngu...@google.com, Sep 2 2016

Issue description

The tests in system_health_smoke_test takes a long time to run, hence should be moved to a separate suite to better manage, e.g: run this suite only on nexus5x fleet on CQ, disable the suite when it goes haywire.
 
Project Member

Comment 1 by sheriffbot@chromium.org, Sep 3 2016

Labels: Hotlist-Google
Summary: Enable system_health_smoke_test on Nexus5x but not Nexus5 (was: Move system_health_smoke_test to a separate suite)
Chatted offline, the simplest way to do this is add an extra flag to "perf/run_tests" script, s.t like "--disable-sh-smoke-test" & add that flag for android_chromium_rel_ng.
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/883442d271d1257505fb99d0802b5a1a0c201d51

commit 883442d271d1257505fb99d0802b5a1a0c201d51
Author: catapult-deps-roller <catapult-deps-roller@chromium.org>
Date: Fri Sep 23 01:28:56 2016

Roll src/third_party/catapult/ b803018ac..7bd10eda4 (9 commits).

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/b803018ac776..7bd10eda47f1

$ git log b803018ac..7bd10eda4 --date=short --no-merges --format='%ad %ae %s'
2016-09-22 nednguyen Make use_live_traffic in FakeNetworkController default to False
2016-09-22 jbudorick [Android] Attempt to grab the forwarder daemon logs on map failure.
2016-09-22 aiolos Remove warning when a ref build is set as monitored.
2016-09-22 charliea [trace model] Add .range accessor for Event
2016-09-22 nednguyen [Telemetry] Enable typ's discovery flags for telemetry's unittest_runner framework
2016-09-22 sullivan Add ability to query for test patterns of length 8.
2016-09-22 bccheng Explicitly initialize the network controller
2016-09-22 nednguyen Add logging to _FileLock to debug race condition when multiple processes download a same file
2016-09-22 nednguyen [Telemetry] Start ts_proxy_server with host=None when --use-live-site flag is enabled

BUG= 634052 , 643649 ,647340,643320

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2365803002
Cr-Commit-Position: refs/heads/master@{#420534}

[modify] https://crrev.com/883442d271d1257505fb99d0802b5a1a0c201d51/DEPS

Cc: nedngu...@google.com
Owner: stip@chromium.org
Mike, now we can add these flags:

+To disable system health smoke tests on Nexus5, add arguments: 
['--skip=benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.*']

+To enable only system health smoke tests on Nexus 5x, add arguments:
['benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.'] 

Cc: -petrcermak@chromium.org
Ping Mike, if you can give the code pointer, I can also make the CL
Ping Mike again.

Comment 8 by stip@chromium.org, Oct 25 2016

Sorry for the delay. I've created https://codereview.chromium.org/2446883002/. This CL simply disables the system health smoke tests on N5, and lets the N5X run the full suite.

If we want, I believe we can try running telemetry_perf_unittests twice, one with only the smoke tests. I don't think that's helpful, but we can look into it if you think that is better.
Project Member

Comment 10 by bugdroid1@chromium.org, Oct 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/26a92ee5fdfde64e4c4ef29b4859114560c9195d

commit 26a92ee5fdfde64e4c4ef29b4859114560c9195d
Author: catapult-deps-roller <catapult-deps-roller@chromium.org>
Date: Wed Oct 26 05:38:02 2016

Roll src/third_party/catapult/ bea54e53a..8d60f90b4 (2 commits).

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/bea54e53a27a..8d60f90b4c84

$ git log bea54e53a..8d60f90b4 --date=short --no-merges --format='%ad %ae %s'
2016-10-25 nednguyen [Telemetry] Actually implement the filtering logic for --skip flag
2016-10-25 benjhayden Reduce usage of Histogram.centralBins.

BUG= 643649 

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2444383005
Cr-Commit-Position: refs/heads/master@{#427598}

[modify] https://crrev.com/26a92ee5fdfde64e4c4ef29b4859114560c9195d/DEPS

Ooops, sorry for unclear request. With you CL in https://codereview.chromium.org/2446883002, we disabled the system health smoke tests on Nexus5, however, we still run everything (other perf unittests + system health smoke) on Nexus 5X. I rememeber that we also consider running only system health smoke tests on Nexus 5x.

To do that, you would add a positional arg to the command line on Nexus 5x:
tools/perf/run_tests .... benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest

Comment 12 by stip@chromium.org, Oct 28 2016

We have the capacity to run the full suite on the N5X, is there a reason why we wouldn't?
Ah, I just worry that we don't have the capacity to run the full suite on N5X. Of course, running more test on more platform is just better for us :P
Status: Fixed (was: Started)
I verified that the system_health_smoke_test are skipped in https://chromium-swarm.appspot.com/user/task/322632096e568e10
Blocking: 660604
Blocking: 660608

Sign in to add a comment