New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 643609 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug

Blocked on:
issue 644832



Sign in to add a comment

Disabling scenarioChromeURLInvalid

Project Member Reported by noyau@chromium.org, Sep 2 2016

Issue description

It fails after chromium roll to b65b322f74351da8b61fe35889348649b56d213d. See https://chromereviews.googleplex.com/499897013/ for the revert.

The failure is that it can't find IDS_ERRORPAGES_HEADING_NOT_AVAILABLE which is "This site can’t be reached". Instead the UI show only a black line (see screenshot)

To Eugene for triage.

 
scenarioChromeURLInvalid.Wait for view with attributes: [view with accessibility label %22This site can’t be reached%22, traits 00000040].png
10.3 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 2 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/5f63d984932c84241fa63f58a275bf5e26ea7234

commit 5f63d984932c84241fa63f58a275bf5e26ea7234
Author: noyau <noyau@google.com>
Date: Fri Sep 02 10:37:55 2016

Cc: cma...@chromium.org
Nit quite sure what happened here but everything works fine in app and test if I run locally. Eric, were you able to reproduce this bug locally? Maybe something was broken downstream and then fixed?
Can not reproduce by running test locally or by running the app itself. Looks like a problem with test which only happens on bots. We should wait until Claude ports it to Earl Grey, but I'm keeping this bug as open and RBS until KIF tests are shut down.

Comment 5 by noyau@chromium.org, Sep 5 2016

It broke when Chromium rolled.

I suspect something changed on error pages.

Cc: -cma...@chromium.org eugene...@chromium.org jyqu...@chromium.org
Owner: cma...@chromium.org
Claude does EG test failing for you on bots, I remember you started converting it last week? CCing Jackie for WebUI, but per comment #4 the error page is displayed correctly if I run the app. I suspect test problem here and if EG version works fine, then we may not even need to fix KIF.
Cc: -eugene...@chromium.org cma...@chromium.org
Owner: eugene...@chromium.org
Ok, so EG tests are also failing:
https://chromereviews.googleplex.com/501987013/
Cc: -jyqu...@chromium.org eugene...@chromium.org
Owner: jyqu...@chromium.org
Jackie, can you take a look. This is not reproducible locally for some reason, and it looks like the breakage came from upstream code.
Thanks for taking a look Jackie. 
Blockedon: 644832
Cc: -cma...@chromium.org jyqu...@chromium.org
Owner: cma...@chromium.org
I think we can land https://chromereviews.googleplex.com/501987013/ now, with both KIF and EG enabled. KIF passes on ToT. Reassigning to Claude as owner of the conversion CL.
Status: Fixed (was: Assigned)
Landed.
Labels: Merge-TBD
[Auto-generated comment by a script] We noticed that this issue is targeted for M-55; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-55 label, otherwise remove Merge-TBD label. Thanks.
Labels: -Merge-TBD
Components: Tests>Disabled
Labels: Test-Disabled

Sign in to add a comment