New issue
Advanced search Search tips

Issue 643575 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocking:
issue 640921



Sign in to add a comment

Histogram GPU.HardwareAccelerationModeEnabled is unmapped

Project Member Reported by ricea@chromium.org, Sep 2 2016

Issue description

The histogram 'GPU.HardwareAccelerationModeEnabled' is present in Chromium
source code but does not appear in histograms.xml. This means that data is
collected for the histogram but nothing useful is done with it.

The histogram was defined in chrome/browser/gpu/gpu_mode_manager.cc at line
56.

https://cs.chromium.org/chromium/src/chrome/browser/gpu/gpu_mode_manager.cc?l=56

It may have moved by the time you read this.

Please remove the histogram 'GPU.HardwareAccelerationModeEnabled' from the
source code. If it was very recently added, it may be worth adding it to
histograms.xml instead, but probably not.

This bug was automatically assigned based on git blame information. If you
are not the correct assignee for this bug, please delete the histogram
anyway.

 

Comment 1 by zmo@chromium.org, Sep 2 2016

This is a User choice option, so it must have the corresponding histogram defined.  Someone might have incorrectly removed it along the way...

Comment 2 by ricea@chromium.org, Sep 5 2016

The histogram was added to the source code in

https://codereview.chromium.org/14113002

It was never added to histograms.xml.

Comment 3 by holte@chromium.org, Aug 22 2017

Components: -Internals>Metrics
Labels: Hotlist-Metrics

Comment 4 by ricea@chromium.org, May 10 2018

Why must it have a corresponding histogram defined? What's the point in having a histogram if no-one ever looks at the data?

Sign in to add a comment