New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 643571 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocking:
issue 640921



Sign in to add a comment

Histogram GPU.SwiftShaderLifetimeEvents is unmapped

Project Member Reported by ricea@chromium.org, Sep 2 2016

Issue description

The histogram 'GPU.SwiftShaderLifetimeEvents' is present in Chromium source
code but does not appear in histograms.xml. This means that data is collected
for the histogram but nothing useful is done with it.

The histogram was defined in content/browser/gpu/gpu_process_host.cc at line
1100.

https://cs.chromium.org/chromium/src/content/browser/gpu/gpu_process_host.cc?l=1100

It may have moved by the time you read this.

Please remove the histogram 'GPU.SwiftShaderLifetimeEvents' from the source
code. If it was very recently added, it may be worth adding it to
histograms.xml instead, but probably not.

This bug was automatically assigned based on git blame information. If you
are not the correct assignee for this bug, please delete the histogram
anyway.

 

Comment 1 by vmi...@chromium.org, May 10 2017

Owner: capn@chromium.org
capn@ could you please take a look?

Comment 2 by capn@chromium.org, Jun 12 2017

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/06ef13df196b1a7f427c5d440e982d48c34623e4

commit 06ef13df196b1a7f427c5d440e982d48c34623e4
Author: Nicolas Capens <capn@google.com>
Date: Tue Jun 13 15:24:07 2017

Map GPU.SwiftShaderLifetimeEvents histogram.

BUG= 643571 

Change-Id: Ic90c22fd024af95006f4c806fad8403c8871a475
Reviewed-on: https://chromium-review.googlesource.com/531756
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Nicolas Capens <nicolascapens@google.com>
Cr-Commit-Position: refs/heads/master@{#479027}
[modify] https://crrev.com/06ef13df196b1a7f427c5d440e982d48c34623e4/tools/metrics/histograms/histograms.xml

Comment 4 by capn@chromium.org, Jun 15 2017

Status: Verified (was: Started)
GPU.SwiftShaderLifetimeEvents appeared in the histogram metrics.

Sign in to add a comment