Histograms matching CloudPrint.* are unmapped |
|||
Issue descriptionThe following histograms are present in Chromium source code but do not appear in histograms.xml. CloudPrint.CapsUpdateInterval defined at chrome/service/cloud_print/printer_job_handler.cc line 725 https://cs.chromium.org/chromium/src/chrome/service/cloud_print/printer_job_handler.cc?l=725 CloudPrint.ServiceUtilitySemanticCapsFailTime defined at chrome/service/service_utility_process_host.cc line 437 https://cs.chromium.org/chromium/src/chrome/service/service_utility_process_host.cc?l=437 CloudPrint.ServiceUtilitySemanticCapsTime defined at chrome/service/service_utility_process_host.cc line 411 https://cs.chromium.org/chromium/src/chrome/service/service_utility_process_host.cc?l=411 CloudPrint.XmppTimeout defined at chrome/service/cloud_print/connector_settings.cc line 70 https://cs.chromium.org/chromium/src/chrome/service/cloud_print/connector_settings.cc?l=70 File and line information may be out-of-date by the time you read this. Please remove these histograms from the source code. If they were very recently added, it may be worth adding them to histograms.xml instead, but probably not. This bug was automatically assigned based on git blame information. If you are not the correct assignee for this bug, please delete the histograms anyway.
,
Sep 2 2016
vitalybuka: Are these histograms useful? Do we want to add or delete?
,
Sep 2 2016
These could be useful if someone was working on improving connector. We added them just before we decided build standalone cups connector (the one on github). Also historical data is not important here, so it should be fine to return them back if needed.
,
Feb 21 2017
,
Feb 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f302b212b55f72414133fb3d7de74a809d85d933 commit f302b212b55f72414133fb3d7de74a809d85d933 Author: vitalybuka <vitalybuka@chromium.org> Date: Thu Feb 23 17:12:45 2017 Remove some unused cloud print histograms. BUG= 643570 Review-Url: https://codereview.chromium.org/2706943003 Cr-Commit-Position: refs/heads/master@{#452527} [modify] https://crrev.com/f302b212b55f72414133fb3d7de74a809d85d933/chrome/service/cloud_print/connector_settings.cc [modify] https://crrev.com/f302b212b55f72414133fb3d7de74a809d85d933/chrome/service/cloud_print/printer_job_handler.cc [modify] https://crrev.com/f302b212b55f72414133fb3d7de74a809d85d933/chrome/service/cloud_print/printer_job_handler.h [modify] https://crrev.com/f302b212b55f72414133fb3d7de74a809d85d933/chrome/service/service_utility_process_host.cc [modify] https://crrev.com/f302b212b55f72414133fb3d7de74a809d85d933/chrome/service/service_utility_process_host.h [modify] https://crrev.com/f302b212b55f72414133fb3d7de74a809d85d933/tools/metrics/histograms/histograms.xml
,
Feb 23 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by vitalyb...@chromium.org
, Sep 2 2016