Histograms matching Net.BlockedTunnelResponse.* are unmapped |
|||||
Issue descriptionThe following histograms are present in Chromium source code but do not appear in histograms.xml. Net.BlockedTunnelResponse.HttpProxy defined at net/http/proxy_client_socket.cc line 78 https://cs.chromium.org/chromium/src/net/http/proxy_client_socket.cc?l=78 Net.BlockedTunnelResponse.HttpsProxy defined at net/http/proxy_client_socket.cc line 73 https://cs.chromium.org/chromium/src/net/http/proxy_client_socket.cc?l=73 File and line information may be out-of-date by the time you read this. Please remove these histograms from the source code. If they were very recently added, it may be worth adding them to histograms.xml instead, but probably not. This bug was automatically assigned based on git blame information. If you are not the correct assignee for this bug, please delete the histograms anyway.
,
May 8 2017
,
May 10 2018
mmenke, please re-triage this.
,
May 10 2018
Since these histograms have been hidden for over two years, think we're fine just removing them.
,
May 10 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/abd9da88b756b8495ec90df40be3b6c766db8d7d commit abd9da88b756b8495ec90df40be3b6c766db8d7d Author: Matt Menke <mmenke@chromium.org> Date: Thu May 10 19:02:58 2018 Remove Net.BlockedTunnelResponse histograms. They aren't in histograms.xml, and that has been the case for multiple years, so they're presumably safe to remove. Bug: 643569 Change-Id: I262be8f7b4c97a6e85b1f58ddb54fe56dd67772b Reviewed-on: https://chromium-review.googlesource.com/1053872 Reviewed-by: Eric Roman <eroman@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#557610} [modify] https://crrev.com/abd9da88b756b8495ec90df40be3b6c766db8d7d/net/http/http_proxy_client_socket.cc [modify] https://crrev.com/abd9da88b756b8495ec90df40be3b6c766db8d7d/net/http/http_proxy_client_socket.h [modify] https://crrev.com/abd9da88b756b8495ec90df40be3b6c766db8d7d/net/http/proxy_client_socket.cc [modify] https://crrev.com/abd9da88b756b8495ec90df40be3b6c766db8d7d/net/http/proxy_client_socket.h [modify] https://crrev.com/abd9da88b756b8495ec90df40be3b6c766db8d7d/net/quic/chromium/quic_proxy_client_socket.cc [modify] https://crrev.com/abd9da88b756b8495ec90df40be3b6c766db8d7d/net/quic/chromium/quic_proxy_client_socket.h [modify] https://crrev.com/abd9da88b756b8495ec90df40be3b6c766db8d7d/net/spdy/chromium/spdy_proxy_client_socket.cc [modify] https://crrev.com/abd9da88b756b8495ec90df40be3b6c766db8d7d/net/spdy/chromium/spdy_proxy_client_socket.h
,
May 10 2018
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by thestig@chromium.org
, Apr 20 2017