Histogram Net.UnspecResolvedIPv6 is unmapped |
||
Issue descriptionThe histogram 'Net.UnspecResolvedIPv6' is present in Chromium source code but does not appear in histograms.xml. This means that data is collected for the histogram but nothing useful is done with it. The histogram was defined in net/dns/host_resolver_impl.cc at line 1595. https://cs.chromium.org/chromium/src/net/dns/host_resolver_impl.cc?l=1595 It may have moved by the time you read this. Please remove the histogram 'Net.UnspecResolvedIPv6' from the source code. If it was very recently added, it may be worth adding it to histograms.xml instead, but probably not. This bug was automatically assigned based on git blame information. If you are not the correct assignee for this bug, please delete the histogram anyway.
,
Apr 21 2017
Yes, yes you can. That file is way too long, I'm happy to delete a few lines of it.
,
Apr 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d7b04a2c8accc7f3c2061fd991186dd176575bc2 commit d7b04a2c8accc7f3c2061fd991186dd176575bc2 Author: mgersh <mgersh@chromium.org> Date: Fri Apr 21 21:49:04 2017 Delete "Net.UnspecResolvedIPv6" histogram This looks it was a short-term experiment from 2013 that never got cleaned up. It's not in histograms.xml. BUG= 643567 Review-Url: https://codereview.chromium.org/2831383003 Cr-Commit-Position: refs/heads/master@{#466458} [modify] https://crrev.com/d7b04a2c8accc7f3c2061fd991186dd176575bc2/net/dns/host_resolver_impl.cc [modify] https://crrev.com/d7b04a2c8accc7f3c2061fd991186dd176575bc2/net/dns/host_resolver_impl.h
,
Apr 21 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by ricea@chromium.org
, Apr 21 2017