Histogram Cellular.SIMLocked is unmapped |
||||
Issue descriptionThe histogram 'Cellular.SIMLocked' is present in Chromium source code but does not appear in histograms.xml. This means that data is collected for the histogram but nothing useful is done with it. The histogram was defined in chromeos/network/device_state.cc at line 110. https://cs.chromium.org/chromium/src/chromeos/network/device_state.cc?l=110 It may have moved by the time you read this. Please remove the histogram 'Cellular.SIMLocked' from the source code. If it was very recently added, it may be worth adding it to histograms.xml instead, but probably not. This bug was automatically assigned based on git blame information. If you are not the correct assignee for this bug, please delete the histogram anyway.
,
Oct 31 2017
We don't use this so I will remove it. If we want to start collecting Cellular SIM usage stats we should come up with a plan and add the stats we need correctly.
,
Oct 31 2017
,
Oct 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9e03b4de668e35a756830660fdea4cd82c710844 commit 9e03b4de668e35a756830660fdea4cd82c710844 Author: Steven Bennetts <stevenjb@chromium.org> Date: Tue Oct 31 19:07:46 2017 Elim unused Cellular.SIMLocked UMA stat Bug: 643565 Change-Id: I3ad3aede53c90ba83f630626a6539daa104ef3a9 Reviewed-on: https://chromium-review.googlesource.com/747042 Reviewed-by: Ben Chan <benchan@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#512896} [modify] https://crrev.com/9e03b4de668e35a756830660fdea4cd82c710844/chromeos/network/device_state.cc [modify] https://crrev.com/9e03b4de668e35a756830660fdea4cd82c710844/chromeos/network/device_state.h
,
Nov 8 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by holte@chromium.org
, Aug 22 2017Labels: Hotlist-Metrics