New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 643564 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocking:
issue 640921



Sign in to add a comment

Histogram GPU.GLResetNotificationStrategy is unmapped

Project Member Reported by ricea@chromium.org, Sep 2 2016

Issue description

The histogram 'GPU.GLResetNotificationStrategy' is present in Chromium source
code but does not appear in histograms.xml. This means that data is collected
for the histogram but nothing useful is done with it.

The histogram was defined in
content/browser/gpu/gpu_data_manager_impl_private.cc at line 214.

https://cs.chromium.org/chromium/src/content/browser/gpu/gpu_data_manager_impl_private.cc?l=214

It may have moved by the time you read this.

Please remove the histogram 'GPU.GLResetNotificationStrategy' from the source
code. If it was very recently added, it may be worth adding it to
histograms.xml instead, but probably not.

This bug was automatically assigned based on git blame information. If you
are not the correct assignee for this bug, please delete the histogram
anyway.

 
Status: Started (was: Assigned)
https://codereview.chromium.org/2302973004/
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b7328ebe02174f20c29a0cb93adfda2ddb8b08ef

commit b7328ebe02174f20c29a0cb93adfda2ddb8b08ef
Author: skyostil <skyostil@chromium.org>
Date: Wed Sep 07 11:53:26 2016

gpu: Remove GPU.GLResetNotificationStrategy histogram

Remove the GPU.GLResetNotificationStrategy UMA histogram, because we
never added it to histograms.xml so the data for it never made it to
the dashboard.

BUG= 643564 

Review-Url: https://codereview.chromium.org/2302973004
Cr-Commit-Position: refs/heads/master@{#416913}

[modify] https://crrev.com/b7328ebe02174f20c29a0cb93adfda2ddb8b08ef/content/browser/gpu/gpu_data_manager_impl_private.cc

Status: Fixed (was: Started)

Sign in to add a comment