Histograms matching ScreenLocker.* are unmapped |
|||
Issue descriptionThe following histograms are present in Chromium source code but do not appear in histograms.xml. ScreenLocker.AuthenticationFailureTime defined at chrome/browser/chromeos/login/lock/screen_locker.cc line 185 https://cs.chromium.org/chromium/src/chrome/browser/chromeos/login/lock/screen_locker.cc?l=185 ScreenLocker.AuthenticationSuccessTime defined at chrome/browser/chromeos/login/lock/screen_locker.cc line 214 https://cs.chromium.org/chromium/src/chrome/browser/chromeos/login/lock/screen_locker.cc?l=214 ScreenLocker.ScreenLockTime defined at chrome/browser/chromeos/login/lock/screen_locker.cc line 523 https://cs.chromium.org/chromium/src/chrome/browser/chromeos/login/lock/screen_locker.cc?l=523 File and line information may be out-of-date by the time you read this. Please remove these histograms from the source code. If they were very recently added, it may be worth adding them to histograms.xml instead, but probably not. This bug was automatically assigned based on git blame information. If you are not the correct assignee for this bug, please delete the histograms anyway.
,
Dec 22 2017
,
May 10 2018
satorux, any updates?
,
May 11 2018
,
May 11 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/189fda007ffd7ca42913ec3edc02d10812ce495f commit 189fda007ffd7ca42913ec3edc02d10812ce495f Author: Satoru Takabayashi <satorux@chromium.org> Date: Fri May 11 05:15:30 2018 Add missing UMA definitions about ScreenLocker to histograms.xml The metrics were added long time ago crrev.com/64367 without the corresponding changes to histograms.xml. The metrics still look interesting hence this change is to update histograms.xml. BUG= 643563 Change-Id: I0ea55648b27b938dc5780932ac9dde31f4e1ff09 Reviewed-on: https://chromium-review.googlesource.com/842427 Commit-Queue: Satoru Takabayashi <satorux@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Reviewed-by: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#557798} [modify] https://crrev.com/189fda007ffd7ca42913ec3edc02d10812ce495f/tools/metrics/histograms/histograms.xml
,
May 11 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by holte@chromium.org
, Aug 22 2017Labels: Hotlist-Metrics