New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 643562 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocking:
issue 640921



Sign in to add a comment

Histograms matching Apps.* are unmapped

Project Member Reported by ricea@chromium.org, Sep 2 2016

Issue description

The following histograms are present in Chromium source code but do not
appear in histograms.xml.

Apps.AppInfoDialogOpenedForLocation defined at
chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.cc line 83
https://cs.chromium.org/chromium/src/chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.cc?l=83

Apps.AppInfoDialogOpenedForType defined at
chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.cc line 80
https://cs.chromium.org/chromium/src/chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.cc?l=80

File and line information may be out-of-date by the time you read this.

Please remove these histograms from the source code. If they were very
recently added, it may be worth adding them to histograms.xml instead, but
probably not.

This bug was automatically assigned based on git blame information. If you
are not the correct assignee for this bug, please delete the histograms
anyway.

 
Owner: benwells@chromium.org
Reassigning to benwells. :)
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ac6c09843c7a5567de5cf0e11d7f915287e74ab2

commit ac6c09843c7a5567de5cf0e11d7f915287e74ab2
Author: benwells <benwells@chromium.org>
Date: Thu Sep 29 01:47:49 2016

Remove unmapped Apps. histograms from AppInfoDialog

BUG= 643562 

Review-Url: https://codereview.chromium.org/2368243005
Cr-Commit-Position: refs/heads/master@{#421710}

[modify] https://crrev.com/ac6c09843c7a5567de5cf0e11d7f915287e74ab2/chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.cc

Status: Fixed (was: Assigned)

Sign in to add a comment