New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 643561 link

Starred by 1 user
Status: Fixed
Owner:
█ cbentzel@chromium.org
Last visit > 30 days ago
Closed: May 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocking:
issue 640921



Sign in to add a comment

Histograms matching DiskCache.* are unmapped

Project Member Reported by ricea@chromium.org, Sep 2 2016 
The following histograms are present in Chromium source code but do not
appear in histograms.xml.

DiskCache.2.MyExperiment_530 defined at
net/disk_cache/blockfile/histogram_macros.h line 88
https://cs.chromium.org/chromium/src/net/disk_cache/blockfile/histogram_macros.h?l=88

DiskCache.2.MyName defined at net/disk_cache/blockfile/histogram_macros.h
line 87
https://cs.chromium.org/chromium/src/net/disk_cache/blockfile/histogram_macros.h?l=87

DiskCache.TrimDelays defined at net/disk_cache/blockfile/eviction.cc line 244
https://cs.chromium.org/chromium/src/net/disk_cache/blockfile/eviction.cc?l=244

File and line information may be out-of-date by the time you read this.

Please remove these histograms from the source code. If they were very
recently added, it may be worth adding them to histograms.xml instead, but
probably not.

This bug was automatically assigned based on git blame information. If you
are not the correct assignee for this bug, please delete the histograms
anyway.

Comment 1 by ricea@chromium.org, Sep 14 2016

Components: Internals>Network>Cache
DiskCache.2.MyExperiment_530 and DiskCache.2.MyName are defined in documentation comments. Nothing needs to be done for those. See  Issue 642625 .


This leaves only one that needs to be fixed:

DiskCache.TrimDelays defined at net/disk_cache/blockfile/eviction.cc line 244
https://cs.chromium.org/chromium/src/net/disk_cache/blockfile/eviction.cc?l=244

Comment 2 by thestig@chromium.org, Apr 20 2017

Owner: cbentzel@chromium.org
cbentzel to reassign.

Comment 3 by holte@chromium.org, Aug 22 2017

Components: -Internals>Metrics
Labels: Hotlist-Metrics

Comment 4 by ricea@chromium.org, May 10 2018 

Still there. Still unmapped. Please remove.

Comment 5 by cbentzel@chromium.org, May 11 2018 

Sorry. Uploading patch.
Project Member

Comment 6 by bugdroid1@chromium.org, May 11 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b846d8706f2650bca655e294b2753182eb67a782

commit b846d8706f2650bca655e294b2753182eb67a782
Author: Chris Bentzel <cbentzel@chromium.org>
Date: Fri May 11 22:19:19 2018

Remove DiskCache.TrimDelays histogram.

This histogram is not defined in histograms.xml and is not being used.

Bug:  643561 
Change-Id: Ib85c40e3f5df88df51caba61f9888e887219ee83
Reviewed-on: https://chromium-review.googlesource.com/1055951
Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Commit-Queue: Chris Bentzel <cbentzel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558036}
[modify] https://crrev.com/b846d8706f2650bca655e294b2753182eb67a782/net/disk_cache/blockfile/eviction.cc

Comment 7 by cbentzel@chromium.org, May 12 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment