Histograms matching Extensions.SettingsQuotaExceeded.* are unmapped |
|||||
Issue descriptionThe following histograms are present in Chromium source code but do not appear in histograms.xml. Extensions.SettingsQuotaExceeded.BytesPerSetting defined at extensions/browser/api/storage/settings_storage_quota_enforcer.cc line 58 https://cs.chromium.org/chromium/src/extensions/browser/api/storage/settings_storage_quota_enforcer.cc?l=58 Extensions.SettingsQuotaExceeded.KeyCount defined at extensions/browser/api/storage/settings_storage_quota_enforcer.cc line 63 https://cs.chromium.org/chromium/src/extensions/browser/api/storage/settings_storage_quota_enforcer.cc?l=63 Extensions.SettingsQuotaExceeded.TotalBytes defined at extensions/browser/api/storage/settings_storage_quota_enforcer.cc line 53 https://cs.chromium.org/chromium/src/extensions/browser/api/storage/settings_storage_quota_enforcer.cc?l=53 File and line information may be out-of-date by the time you read this. Please remove these histograms from the source code. If they were very recently added, it may be worth adding them to histograms.xml instead, but probably not. This bug was automatically assigned based on git blame information. If you are not the correct assignee for this bug, please delete the histograms anyway.
,
Sep 2 2016
ricow@ thank you for looking at it. CC +kalman who added the comment "TODO(kalman): These hisograms are both silly and untracked. Fix." Since we've managed to live without them for 3 years, I'd like to venture the possibility that we never needed them to begin with.
,
Sep 9 2016
ricea@: kalman@ is no longer on Chrome either. Punting to rdevlin.cronin who might know what to do with this.
,
Sep 12 2016
"What to do" is simple: remove the histograms. They've been there for 3.5 years, and kalman@ noted 3 years ago that they were untracked. If we've managed to go this long without anyone caring enough about the data to add the histograms to histograms.xml, we can be extremely confident that no-one ever will. The only questions remaining are who is going to write the CL and who is going to approve it.
,
Sep 12 2016
@4 I'm not sure it's quite so cut-and-dried in all cases, but in this one, it probably is. I'm happy to handle the CL. mpearson@, in the past, you've requested that histograms like this that we're removing be added to histograms.xml with the <obsolete> tag. Is that your preference here as well?
,
Sep 12 2016
That's my preference but it's not required. It's mostly a judgment call about how willing the code submitter is to do add the entry, how valuable it would be to glance at the old data, whether the old histogram made any sense (i.e., can a description be written for it?), and whether the name seems common enough that it might be inadvertently reused in the future.
,
Sep 20 2016
Not sure why bugdroid didn't mention it, but revision a5dd79dcca3750d85310fb5cbf2b22f56b6f754b fixes this. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by ricow@chromium.org
, Sep 2 2016Owner: dcheng@chromium.org