Histogram SBIRS.StateStoreInit is unmapped |
||
Issue descriptionThe histogram 'SBIRS.StateStoreInit' is present in Chromium source code but does not appear in histograms.xml. This means that data is collected for the histogram but nothing useful is done with it. The histogram was defined in chrome/browser/safe_browsing/incident_reporting/state_store.cc at line 144. https://cs.chromium.org/chromium/src/chrome/browser/safe_browsing/incident_reporting/state_store.cc?l=144 It may have moved by the time you read this. Please remove the histogram 'SBIRS.StateStoreInit' from the source code. If it was very recently added, it may be worth adding it to histograms.xml instead, but probably not. This bug was automatically assigned based on git blame information. If you are not the correct assignee for this bug, please delete the histogram anyway.
,
Oct 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c47e6afe273594b3fc1a2fd1c148787abceb0e94 commit c47e6afe273594b3fc1a2fd1c148787abceb0e94 Author: proberge <proberge@chromium.org> Date: Tue Oct 03 18:03:45 2017 Fix wrong histogram name StateStoreInitResult The code uses SBIRS.StateStoreInit. No such histogram exists as the relevant histogram was named SBIRS.StateStoreInitResult instead. Bug: 643557 Change-Id: Ie3c9fecb779ad16da4a3910a1b7b037dc36f4c91 Reviewed-on: https://chromium-review.googlesource.com/695744 Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Commit-Queue: proberge <proberge@chromium.org> Cr-Commit-Position: refs/heads/master@{#506101} [modify] https://crrev.com/c47e6afe273594b3fc1a2fd1c148787abceb0e94/tools/metrics/histograms/histograms.xml
,
Oct 3 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by holte@chromium.org
, Aug 22 2017Labels: Hotlist-Metrics