New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 643555 link

Starred by 1 user
Status: Fixed
Owner:
█ perkj@chromium.org
Last visit > 30 days ago
Closed: Sep 2016
Cc:
skare@chromium.org
isherman@chromium.org
asvitk...@chromium.org
█ rkaplow@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocking:
issue 640921



Sign in to add a comment

Histogram Platform.WebRtcNEONFound is unmapped

Project Member Reported by ricea@chromium.org, Sep 2 2016 
The histogram 'Platform.WebRtcNEONFound' is present in Chromium source code
but does not appear in histograms.xml. This means that data is collected for
the histogram but nothing useful is done with it.

The histogram was defined in content/renderer/render_frame_impl.cc at line
5738.

https://cs.chromium.org/chromium/src/content/renderer/render_frame_impl.cc?l=5738

It may have moved by the time you read this.

Please remove the histogram 'Platform.WebRtcNEONFound' from the source code.
If it was very recently added, it may be worth adding it to histograms.xml
instead, but probably not.

This bug was automatically assigned based on git blame information. If you
are not the correct assignee for this bug, please delete the histogram
anyway.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 2 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c39945de8806cab871e462212c3e82aab705c175

commit c39945de8806cab871e462212c3e82aab705c175
Author: perkj <perkj@chromium.org>
Date: Fri Sep 02 09:32:13 2016

Remove UMA 'Platform.WebRtcNEONFound These lines where last touched by me in a cl two years ago when I moved it,  https://codereview.chromium.org/294043015. There is no owner for this and does not exist in histograms.xml.

BUG= 643555 
TBR=jochen@chromium.org

Review-Url: https://codereview.chromium.org/2300313002
Cr-Commit-Position: refs/heads/master@{#416219}

[modify] https://crrev.com/c39945de8806cab871e462212c3e82aab705c175/content/renderer/render_frame_impl.cc

Comment 2 by perkj@chromium.org, Sep 2 2016

Status: Fixed (was: Assigned)

Comment 3 by ricea@chromium.org, Sep 2 2016 

I tried to follow renames when getting blame information out of git, but maybe I didn't do it well enough. Thank you for taking the time to remove the histogram anyway!

Comment 4 by perkj@chromium.org, Sep 2 2016 

I was not able to figure out who added it initially. But is says WebRtc
which I belong to and its obviously not used :->
►

Sign in to add a comment