New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 643553 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocking:
issue 640921



Sign in to add a comment

Histograms matching TabCapture.* are unmapped

Project Member Reported by ricea@chromium.org, Sep 2 2016

Issue description

The following histograms are present in Chromium source code but do not
appear in histograms.xml.

TabCapture.CopyTimeBitmap defined at
content/browser/media/capture/web_contents_video_capture_device.cc line 848
https://cs.chromium.org/chromium/src/content/browser/media/capture/web_contents_video_capture_device.cc?l=848

TabCapture.CopyTimeVideoFrame defined at
content/browser/media/capture/web_contents_video_capture_device.cc line 872
https://cs.chromium.org/chromium/src/content/browser/media/capture/web_contents_video_capture_device.cc?l=872

File and line information may be out-of-date by the time you read this.

Please remove these histograms from the source code. If they were very
recently added, it may be worth adding them to histograms.xml instead, but
probably not.

This bug was automatically assigned based on git blame information. If you
are not the correct assignee for this bug, please delete the histograms
anyway.

 

Comment 1 by nick@chromium.org, Oct 10 2016

Owner: m...@chromium.org
Yuri maintains this nowadays.

Comment 2 by m...@chromium.org, Oct 19 2016

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/77b25be5e3d76befe8ad8e0a58eb4d8fdda44655

commit 77b25be5e3d76befe8ad8e0a58eb4d8fdda44655
Author: miu <miu@chromium.org>
Date: Wed Oct 19 22:28:35 2016

Clean-up: Remove unused logging/UMA's from web_contents_video_capture_device.cc.

BUG= 643553 

Review-Url: https://chromiumcodereview.appspot.com/2429503006
Cr-Commit-Position: refs/heads/master@{#426309}

[modify] https://crrev.com/77b25be5e3d76befe8ad8e0a58eb4d8fdda44655/content/browser/media/capture/web_contents_video_capture_device.cc

Comment 4 by m...@chromium.org, Oct 19 2016

Status: Fixed (was: Started)

Sign in to add a comment