New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 643552 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocking:
issue 640921



Sign in to add a comment

Histogram Omnibox.SearchProvider.GetMostRecentKeywordTermsDefaultProviderTime is unmapped

Project Member Reported by ricea@chromium.org, Sep 2 2016

Issue description

The histogram
'Omnibox.SearchProvider.GetMostRecentKeywordTermsDefaultProviderTime' is
present in Chromium source code but does not appear in histograms.xml. This
means that data is collected for the histogram but nothing useful is done
with it.

The histogram was defined in components/omnibox/browser/search_provider.cc at
line 639.

https://cs.chromium.org/chromium/src/components/omnibox/browser/search_provider.cc?l=639

It may have moved by the time you read this.

Please remove the histogram
'Omnibox.SearchProvider.GetMostRecentKeywordTermsDefaultProviderTime' from
the source code. If it was very recently added, it may be worth adding it to
histograms.xml instead, but probably not.

This bug was automatically assigned based on git blame information. If you
are not the correct assignee for this bug, please delete the histogram
anyway.

 
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/345f6dba8f36087f3f6d895074b545fd3734fddc

commit 345f6dba8f36087f3f6d895074b545fd3734fddc
Author: mpearson <mpearson@chromium.org>
Date: Wed Sep 14 00:24:34 2016

Add Omnibox Histogram to XML File

I had overlooked this in previous submission.  This histogram would be useful.

BUG= 643552 

Review-Url: https://codereview.chromium.org/2337103005
Cr-Commit-Position: refs/heads/master@{#418436}

[modify] https://crrev.com/345f6dba8f36087f3f6d895074b545fd3734fddc/tools/metrics/histograms/histograms.xml

Status: Fixed (was: Started)

Sign in to add a comment