New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 643551 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocking:
issue 640921



Sign in to add a comment

Histogram Extensions.NetworkDelayStartup is unmapped

Project Member Reported by ricea@chromium.org, Sep 2 2016

Issue description

The histogram 'Extensions.NetworkDelayStartup' is present in Chromium source
code but does not appear in histograms.xml. This means that data is collected
for the histogram but nothing useful is done with it.

The histogram was defined in
extensions/browser/api/web_request/web_request_api.cc at line 1633.

https://cs.chromium.org/chromium/src/extensions/browser/api/web_request/web_request_api.cc?l=1633

It may have moved by the time you read this.

Please remove the histogram 'Extensions.NetworkDelayStartup' from the source
code. If it was very recently added, it may be worth adding it to
histograms.xml instead, but probably not.

This bug was automatically assigned based on git blame information. If you
are not the correct assignee for this bug, please delete the histogram
anyway.

 
Owner: ----
Status: Available (was: Assigned)
I'm not on the Chrome project anymore.

Comment 2 by ricea@chromium.org, Sep 14 2016

Owner: ricea@chromium.org
Status: Assigned (was: Available)
I'll delete it myself.

Comment 3 by ricea@chromium.org, Sep 14 2016

Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/270969d1cb77d6314dfb0f4bea0d76f8a919eca4

commit 270969d1cb77d6314dfb0f4bea0d76f8a919eca4
Author: ricea <ricea@chromium.org>
Date: Fri Sep 16 04:33:15 2016

Remove Extensions.NetworkDelayStartup histogram

This histogram was added to the source in 2012, but never added to
histograms.xml. So noone ever looked at the data. Remove it.

Also add an obsolete entry to histograms.xml, so noone tries to reuse
the name.

BUG= 643551 

Review-Url: https://codereview.chromium.org/2345433002
Cr-Commit-Position: refs/heads/master@{#419102}

[modify] https://crrev.com/270969d1cb77d6314dfb0f4bea0d76f8a919eca4/extensions/browser/api/web_request/web_request_api.cc
[modify] https://crrev.com/270969d1cb77d6314dfb0f4bea0d76f8a919eca4/tools/metrics/histograms/histograms.xml

Comment 5 by ricea@chromium.org, Sep 16 2016

Status: Fixed (was: Started)

Sign in to add a comment