New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 643546 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocking:
issue 640921



Sign in to add a comment

Histogram GPU.BlockStatusForClient3DAPIs is unmapped

Project Member Reported by ricea@chromium.org, Sep 2 2016

Issue description

The histogram 'GPU.BlockStatusForClient3DAPIs' is present in Chromium source
code but does not appear in histograms.xml. This means that data is collected
for the histogram but nothing useful is done with it.

The histogram was defined in
content/browser/gpu/gpu_data_manager_impl_private.cc at line 1250.

https://cs.chromium.org/chromium/src/content/browser/gpu/gpu_data_manager_impl_private.cc?l=1250

It may have moved by the time you read this.

Please remove the histogram 'GPU.BlockStatusForClient3DAPIs' from the source
code. If it was very recently added, it may be worth adding it to
histograms.xml instead, but probably not.

This bug was automatically assigned based on git blame information. If you
are not the correct assignee for this bug, please delete the histogram
anyway.

 
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/965572bee4585e5dc0fc0222385f3df2dd815678

commit 965572bee4585e5dc0fc0222385f3df2dd815678
Author: joostouwerling <joostouwerling@google.com>
Date: Thu Sep 15 18:05:06 2016

Remove unmapped histogram GPU.BlockStatusForClient3DAPIs

It was never added to histograms.xml

BUG= 643546 

Review-Url: https://codereview.chromium.org/2338363004
Cr-Commit-Position: refs/heads/master@{#418903}

[modify] https://crrev.com/965572bee4585e5dc0fc0222385f3df2dd815678/content/browser/gpu/gpu_data_manager_impl_private.cc

Comment 3 by thakis@chromium.org, Sep 15 2016

Cc: joostouwerling@google.com
Status: Fixed (was: Available)
joostouwerling@google.com fixed, but he isn't a project member per db (yet?), so I can't put him in the owner field.

Sign in to add a comment