Histograms matching GCM.* are unmapped |
|||
Issue descriptionThe following histograms are present in Chromium source code but do not appear in histograms.xml. GCM.DataMessageReceived defined at components/gcm_driver/gcm_stats_recorder_impl.cc line 404 https://cs.chromium.org/chromium/src/components/gcm_driver/gcm_stats_recorder_impl.cc?l=404 GCM.IncomingSendErrors defined at components/gcm_driver/gcm_stats_recorder_impl.cc line 539 https://cs.chromium.org/chromium/src/components/gcm_driver/gcm_stats_recorder_impl.cc?l=539 GCM.RegistrationRequest defined at components/gcm_driver/gcm_stats_recorder_impl.cc line 309 https://cs.chromium.org/chromium/src/components/gcm_driver/gcm_stats_recorder_impl.cc?l=309 GCM.SendMessageStatus defined at components/gcm_driver/gcm_stats_recorder_impl.cc line 522 https://cs.chromium.org/chromium/src/components/gcm_driver/gcm_stats_recorder_impl.cc?l=522 GCM.UnregistrationRequest defined at components/gcm_driver/gcm_stats_recorder_impl.cc line 345 https://cs.chromium.org/chromium/src/components/gcm_driver/gcm_stats_recorder_impl.cc?l=345 File and line information may be out-of-date by the time you read this. Please remove these histograms from the source code. If they were very recently added, it may be worth adding them to histograms.xml instead, but probably not. This bug was automatically assigned based on git blame information. If you are not the correct assignee for this bug, please delete the histograms anyway.
,
Sep 26 2016
,
Sep 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d91a3c3fbca28503c5375150db219c2182e3d576 commit d91a3c3fbca28503c5375150db219c2182e3d576 Author: peter <peter@chromium.org> Date: Tue Sep 27 11:05:35 2016 Create mappings for unmapped GCM-related histograms BUG= 643545 Review-Url: https://codereview.chromium.org/2365363002 Cr-Commit-Position: refs/heads/master@{#421167} [modify] https://crrev.com/d91a3c3fbca28503c5375150db219c2182e3d576/tools/metrics/histograms/histograms.xml
,
Sep 28 2016
We'll assess whether these are worth it once we've collected sufficient data, and then decide to keep or remove them. Marking this as fixed. |
|||
►
Sign in to add a comment |
|||
Comment 1 by peter@chromium.org
, Sep 26 2016Status: Started (was: Assigned)