Histogram WebCore.IndexedDB.Context.ForceCloseReason is unmapped |
||||
Issue descriptionThe histogram 'WebCore.IndexedDB.Context.ForceCloseReason' is present in Chromium source code but does not appear in histograms.xml. This means that data is collected for the histogram but nothing useful is done with it. The histogram was defined in content/browser/indexed_db/indexed_db_context_impl.cc at line 390. https://cs.chromium.org/chromium/src/content/browser/indexed_db/indexed_db_context_impl.cc?l=390 It may have moved by the time you read this. Please remove the histogram 'WebCore.IndexedDB.Context.ForceCloseReason' from the source code. If it was very recently added, it may be worth adding it to histograms.xml instead, but probably not. This bug was automatically assigned based on git blame information. If you are not the correct assignee for this bug, please delete the histogram anyway.
,
Sep 5 2016
WebCore.IndexedDB.Context.ForceCloseReason vs. WebCore.IndexedDB.Context.ForcedCloseReason Since it's been that way for two years, I think the "you didn't need it after all" principle still applies.
,
Apr 21 2017
Still unmapped. If you really wanted this data, you could have it with a one-character change to histograms.xml. But it would probably be better just to remove it from both.
,
Aug 22 2017
,
Oct 11 2017
Sorry for long delay. I'm going to fix histograms.xml, take a look at the results, and then likely delete the UMA reporting as it is obviously unused.
,
Oct 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4fe9f7fda6cbad14caaae7060dd53e133c7833d9 commit 4fe9f7fda6cbad14caaae7060dd53e133c7833d9 Author: Chris Mumford <cmumford@chromium.org> Date: Thu Oct 12 23:59:26 2017 IndexedDB: Fixed ForceCloseReason UMA mapping. Bug: 643544 Change-Id: Ie3546e00fe67d03c9683356b06865f5121e97833 Reviewed-on: https://chromium-review.googlesource.com/713962 Reviewed-by: Steven Holte <holte@chromium.org> Commit-Queue: Chris Mumford <cmumford@chromium.org> Cr-Commit-Position: refs/heads/master@{#508552} [modify] https://crrev.com/4fe9f7fda6cbad14caaae7060dd53e133c7833d9/tools/metrics/histograms/histograms.xml
,
Nov 1 2017
,
Nov 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fb6ac92619231d92381b64ae41442c65b454b3df commit fb6ac92619231d92381b64ae41442c65b454b3df Author: Chris Mumford <cmumford@chromium.org> Date: Tue Nov 28 18:25:42 2017 IndexedDB: Add missing UMA enum mapping for ForceCloseReason. In 48bedbd2773df a new reason was added to force an Indexed DB closed: for migration. This change failed to add a value in enums.xml for UMA. Not strictly related to 643544, but was noticed when reviewing UMA values post change. Bug: 643544 Change-Id: I793df6967a80046775babb1cf0af242b2c148374 Reviewed-on: https://chromium-review.googlesource.com/792031 Reviewed-by: Joshua Bell <jsbell@chromium.org> Reviewed-by: Victor Costan <pwnall@chromium.org> Commit-Queue: Chris Mumford <cmumford@chromium.org> Cr-Commit-Position: refs/heads/master@{#519756} [modify] https://crrev.com/fb6ac92619231d92381b64ae41442c65b454b3df/content/browser/indexed_db/indexed_db_context_impl.h [modify] https://crrev.com/fb6ac92619231d92381b64ae41442c65b454b3df/tools/metrics/histograms/enums.xml |
||||
►
Sign in to add a comment |
||||
Comment 1 by jsb...@chromium.org
, Sep 2 2016