New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 643542 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocking:
issue 640921



Sign in to add a comment

Histogram Profile.PolicySize is unmapped

Project Member Reported by ricea@chromium.org, Sep 2 2016

Issue description

The histogram 'Profile.PolicySize' is present in Chromium source code but
does not appear in histograms.xml. This means that data is collected for the
histogram but nothing useful is done with it.

The histogram was defined in chrome/browser/profiles/profile_manager.cc at
line 206.

https://cs.chromium.org/chromium/src/chrome/browser/profiles/profile_manager.cc?l=206

It may have moved by the time you read this.

Please remove the histogram 'Profile.PolicySize' from the source code. If it
was very recently added, it may be worth adding it to histograms.xml instead,
but probably not.

This bug was automatically assigned based on git blame information. If you
are not the correct assignee for this bug, please delete the histogram
anyway.

 
Cc: atwilson@chromium.org
Owner: bartfab@chromium.org
Cc: -atwilson@chromium.org
Components: Enterprise
Owner: ----
Status: Available (was: Assigned)
Putting in triage queue.

Comment 3 by dskaram@google.com, Sep 8 2016

Owner: pastarmovj@chromium.org
Status: Started (was: Available)
I will clean this up now.
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 24 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2e7df988d039c10d7adce428a762dc13ef3812a0

commit 2e7df988d039c10d7adce428a762dc13ef3812a0
Author: pastarmovj <pastarmovj@chromium.org>
Date: Thu Nov 24 17:21:35 2016

Remove unused histogram count.

It has been added in the code in 2013 and has never been added to the
histograms.xml file so presumable nobody has ever cared about its value.

BUG= 643542 
TEST=none

Review-Url: https://codereview.chromium.org/2516973006
Cr-Commit-Position: refs/heads/master@{#434355}

[modify] https://crrev.com/2e7df988d039c10d7adce428a762dc13ef3812a0/chrome/browser/profiles/profile_manager.cc

Status: Fixed (was: Started)

Sign in to add a comment