New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 643540 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocking:
issue 640921



Sign in to add a comment

Histogram Extension.ExternalProvidersReadyAfter is unmapped

Project Member Reported by ricea@chromium.org, Sep 2 2016

Issue description

The histogram 'Extension.ExternalProvidersReadyAfter' is present in Chromium
source code but does not appear in histograms.xml. This means that data is
collected for the histogram but nothing useful is done with it.

The histogram was defined in chrome/browser/extensions/extension_service.cc
at line 1318.

https://cs.chromium.org/chromium/src/chrome/browser/extensions/extension_service.cc?l=1318

It may have moved by the time you read this.

Please remove the histogram 'Extension.ExternalProvidersReadyAfter' from the
source code. If it was very recently added, it may be worth adding it to
histograms.xml instead, but probably not.

This bug was automatically assigned based on git blame information. If you
are not the correct assignee for this bug, please delete the histogram
anyway.

 
Cc: atwilson@chromium.org
Owner: bartfab@chromium.org
Cc: -atwilson@chromium.org
Components: Enterprise
Owner: ----
Status: Available (was: Assigned)
Putting in triage queue.

Comment 3 by dskaram@google.com, Sep 8 2016

Components: -Enterprise Platform>Extensions

Comment 4 by ricea@chromium.org, Apr 21 2017

Status: Untriaged (was: Available)
Putting in triage queue harder. Apologies in advance if this bugs people triaging the Internals>Metrics component.

Comment 5 by ricea@chromium.org, May 10 2018

Owner: ricea@chromium.org
Status: Started (was: Untriaged)
Looks like there is no-one available to do this. Doing it myself.
Project Member

Comment 6 by bugdroid1@chromium.org, May 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9d7b66e9bbdebe2076b6b1aeda946195a4b47737

commit 9d7b66e9bbdebe2076b6b1aeda946195a4b47737
Author: Adam Rice <ricea@chromium.org>
Date: Thu May 10 14:44:01 2018

Remove histogram Extension.ExternalProvidersReadyAfter

Histogram Extension.ExternalProvidersReadyAfter has existed since at
least 2012, but never been mapped. This implies that no-one has ever
been interested enough to look at the data, and so it is providing no
value to users.

Remove it.

BUG= 643540 

Change-Id: I472e5e515469a084fcb1b0ad6ce18826f40ad7ea
Reviewed-on: https://chromium-review.googlesource.com/1053669
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557514}
[modify] https://crrev.com/9d7b66e9bbdebe2076b6b1aeda946195a4b47737/chrome/browser/extensions/extension_service.cc

Comment 7 by ricea@chromium.org, May 10 2018

Status: Fixed (was: Started)

Sign in to add a comment