New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 643539 link

Starred by 1 user
Status: Fixed
Owner:
█ jialiul@chromium.org
Last visit > 30 days ago
Closed: Sep 2016
Cc:
skare@chromium.org
isherman@chromium.org
asvitk...@chromium.org
█ rkaplow@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocking:
issue 640921



Sign in to add a comment

Histogram SBClientMalware.ResourceUrlMatchesBadIp is unmapped

Project Member Reported by ricea@chromium.org, Sep 2 2016 
The histogram 'SBClientMalware.ResourceUrlMatchesBadIp' is present in
Chromium source code but does not appear in histograms.xml. This means that
data is collected for the histogram but nothing useful is done with it.

The histogram was defined in
chrome/browser/safe_browsing/client_side_detection_host.cc at line 646.

https://cs.chromium.org/chromium/src/chrome/browser/safe_browsing/client_side_detection_host.cc?l=646

It may have moved by the time you read this.

Please remove the histogram 'SBClientMalware.ResourceUrlMatchesBadIp' from
the source code. If it was very recently added, it may be worth adding it to
histograms.xml instead, but probably not.

This bug was automatically assigned based on git blame information. If you
are not the correct assignee for this bug, please delete the histogram
anyway.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 2 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b39bd2efd5cf400842b08d3de4b9dba83dea4708

commit b39bd2efd5cf400842b08d3de4b9dba83dea4708
Author: jialiul <jialiul@chromium.org>
Date: Fri Sep 02 18:12:23 2016

fix spelling of SBClientMalware.ResourceUrlMatchedBadIp UMA metric

BUG= 643539 

Review-Url: https://codereview.chromium.org/2300293003
Cr-Commit-Position: refs/heads/master@{#416300}

[modify] https://crrev.com/b39bd2efd5cf400842b08d3de4b9dba83dea4708/chrome/browser/safe_browsing/client_side_detection_host.cc

Comment 2 by jialiul@chromium.org, Sep 2 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment