New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 643537 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocking:
issue 640921



Sign in to add a comment

Histogram DBus.RejectedSignalCount is unmapped

Project Member Reported by ricea@chromium.org, Sep 2 2016

Issue description

The histogram 'DBus.RejectedSignalCount' is present in Chromium source code
but does not appear in histograms.xml. This means that data is collected for
the histogram but nothing useful is done with it.

The histogram was defined in dbus/object_proxy.cc at line 506.

https://cs.chromium.org/chromium/src/dbus/object_proxy.cc?l=506

It may have moved by the time you read this.

Please remove the histogram 'DBus.RejectedSignalCount' from the source code.
If it was very recently added, it may be worth adding it to histograms.xml
instead, but probably not.

This bug was automatically assigned based on git blame information. If you
are not the correct assignee for this bug, please delete the histogram
anyway.

 

Comment 1 by ricea@chromium.org, Apr 21 2017

Cc: haruki@chromium.org
Owner: hashimoto@chromium.org
Switching owner to hashimoto@ as haruki@ has never visited this bug tracker.
Status: Started (was: Assigned)
Made a CL https://codereview.chromium.org/2837943004/
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/72254d5183b29735f1cfe999cc7926f55c4dedb0

commit 72254d5183b29735f1cfe999cc7926f55c4dedb0
Author: hashimoto <hashimoto@chromium.org>
Date: Tue Apr 25 07:13:31 2017

dbus: Stop collecting DBus.RejectedSignalCount histogram

Also, use shorter timeout for SignalSenderVerificationTest.TestSignalRejected
which was disabled because of its slowness.

BUG= 407063 , 643537 
TEST=dbus_unittests

Review-Url: https://codereview.chromium.org/2837943004
Cr-Commit-Position: refs/heads/master@{#466912}

[modify] https://crrev.com/72254d5183b29735f1cfe999cc7926f55c4dedb0/dbus/object_proxy.cc
[modify] https://crrev.com/72254d5183b29735f1cfe999cc7926f55c4dedb0/dbus/signal_sender_verification_unittest.cc

Status: Fixed (was: Started)

Sign in to add a comment