Histogram StorageMonitor.EjectWinLock is unmapped |
||
Issue descriptionThe histogram 'StorageMonitor.EjectWinLock' is present in Chromium source code but does not appear in histograms.xml. This means that data is collected for the histogram but nothing useful is done with it. The histogram was defined in components/storage_monitor/volume_mount_watcher_win.cc at line 265. https://cs.chromium.org/chromium/src/components/storage_monitor/volume_mount_watcher_win.cc?l=265 It may have moved by the time you read this. Please remove the histogram 'StorageMonitor.EjectWinLock' from the source code. If it was very recently added, it may be worth adding it to histograms.xml instead, but probably not. This bug was automatically assigned based on git blame information. If you are not the correct assignee for this bug, please delete the histogram anyway.
,
Apr 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/822449eabd6f5c248beabea55fecc304f783d7a2 commit 822449eabd6f5c248beabea55fecc304f783d7a2 Author: thestig <thestig@chromium.org> Date: Fri Apr 21 00:41:35 2017 Remove more unmapped media galleries histograms. It's storage_monitor code, but it was mostly used for media galleries. BUG= 643534 , 643535 Review-Url: https://codereview.chromium.org/2837453002 Cr-Commit-Position: refs/heads/master@{#466203} [modify] https://crrev.com/822449eabd6f5c248beabea55fecc304f783d7a2/components/storage_monitor/storage_monitor_linux.cc [modify] https://crrev.com/822449eabd6f5c248beabea55fecc304f783d7a2/components/storage_monitor/volume_mount_watcher_win.cc
,
Apr 21 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by thestig@chromium.org
, Apr 20 2017