New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 643534 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocking:
issue 640921



Sign in to add a comment

Histogram RemovableDeviceNotificationsLinux.device_file_system_uuid_available is unmapped

Project Member Reported by ricea@chromium.org, Sep 2 2016

Issue description

The histogram
'RemovableDeviceNotificationsLinux.device_file_system_uuid_available' is
present in Chromium source code but does not appear in histograms.xml. This
means that data is collected for the histogram but nothing useful is done
with it.

The histogram was defined in
components/storage_monitor/storage_monitor_linux.cc at line 59.

https://cs.chromium.org/chromium/src/components/storage_monitor/storage_monitor_linux.cc?l=59

It may have moved by the time you read this.

Please remove the histogram
'RemovableDeviceNotificationsLinux.device_file_system_uuid_available' from
the source code. If it was very recently added, it may be worth adding it to
histograms.xml instead, but probably not.

This bug was automatically assigned based on git blame information. If you
are not the correct assignee for this bug, please delete the histogram
anyway.

 
Owner: thestig@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/822449eabd6f5c248beabea55fecc304f783d7a2

commit 822449eabd6f5c248beabea55fecc304f783d7a2
Author: thestig <thestig@chromium.org>
Date: Fri Apr 21 00:41:35 2017

Remove more unmapped media galleries histograms.

It's storage_monitor code, but it was mostly used for media galleries.

BUG= 643534 , 643535 

Review-Url: https://codereview.chromium.org/2837453002
Cr-Commit-Position: refs/heads/master@{#466203}

[modify] https://crrev.com/822449eabd6f5c248beabea55fecc304f783d7a2/components/storage_monitor/storage_monitor_linux.cc
[modify] https://crrev.com/822449eabd6f5c248beabea55fecc304f783d7a2/components/storage_monitor/volume_mount_watcher_win.cc

Status: Fixed (was: Assigned)

Sign in to add a comment