New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 643533 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Jan 2
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocking:
issue 640921



Sign in to add a comment

Histogram Storage.BlobItemSize.CacheEntry is unmapped

Project Member Reported by ricea@chromium.org, Sep 2 2016

Issue description

The histogram 'Storage.BlobItemSize.CacheEntry' is present in Chromium source
code but does not appear in histograms.xml. This means that data is collected
for the histogram but nothing useful is done with it.

The histogram was defined in storage/browser/blob/blob_storage_context.cc at
line 341.

https://cs.chromium.org/chromium/src/storage/browser/blob/blob_storage_context.cc?l=341

It may have moved by the time you read this.

Please remove the histogram 'Storage.BlobItemSize.CacheEntry' from the source
code. If it was very recently added, it may be worth adding it to
histograms.xml instead, but probably not.

This bug was automatically assigned based on git blame information. If you
are not the correct assignee for this bug, please delete the histogram
anyway.

 

Comment 1 by holte@chromium.org, Aug 22 2017

Components: -Internals>Metrics
Labels: Hotlist-Metrics
Owner: morlovich@chromium.org
Components: Blink>FileAPI
Owner: ----
Status: Available (was: Assigned)
Routing...

Comment 4 by mek@chromium.org, Nov 27 2017

Cc: mek@chromium.org gavinp@chromium.org
Owner: dmu...@chromium.org
https://codereview.chromium.org/1108083002 added the code for this histogram. On one hand since apparently we've never looked at the data deleting the histogram might make sense, but it seems weirdly inconsistent if that would be the only element type without UMA histograms.

Comment 5 by dmu...@chromium.org, Nov 27 2017

Ah yeah it looks like Gavin forgot to add the histograms xml file to the change. This is a bug, we would like to know our size distribution disk-cache backed blobs.

Comment 6 by ricea@chromium.org, May 10 2018

#5 If you need the information, please add the histogram to histograms.xml.
Components: Blink>Storage>FileAPI
Components: -Blink>FileAPI
Status: Assigned (was: Available)
Status: WontFix (was: Assigned)
Removed these histograms, yay!

Sign in to add a comment