New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 643532 link

Starred by 1 user
Status: Assigned
Owner:
bsep@chromium.org
Cc:
pmonette@chromium.org
finnur@chromium.org
sky@chromium.org
skare@chromium.org
isherman@chromium.org
asvitk...@chromium.org
█ rkaplow@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocking:
issue 640921



Sign in to add a comment

Histogram ConflictingModule.UserSelection is unmapped

Project Member Reported by ricea@chromium.org, Sep 2 2016 
The histogram 'ConflictingModule.UserSelection' is present in Chromium source
code but does not appear in histograms.xml. This means that data is collected
for the histogram but nothing useful is done with it.

The histogram was defined in
chrome/browser/ui/views/conflicting_module_view_win.cc at line 155.

https://cs.chromium.org/chromium/src/chrome/browser/ui/views/conflicting_module_view_win.cc?l=155

It may have moved by the time you read this.

Please remove the histogram 'ConflictingModule.UserSelection' from the source
code. If it was very recently added, it may be worth adding it to
histograms.xml instead, but probably not.

This bug was automatically assigned based on git blame information. If you
are not the correct assignee for this bug, please delete the histogram
anyway.
Project Member

Comment 1 by sheriffbot@chromium.org, Sep 4 2017

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 2 by mpear...@chromium.org, Sep 5 2017

Cc: pmonette@chromium.org
Owner: bsep@chromium.org
Status: Assigned (was: Untriaged)
Arbitrarily assigning to someone who touched this code recently who may know if this metric can be retired, and CCing someone else you might also be relevant.

Comment 3 by ricea@chromium.org, May 10 2018 

Still there. Still not used. Please remove it.
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 12 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/66e935ac491542bde00638e1484ca2c5fdbbf084

commit 66e935ac491542bde00638e1484ca2c5fdbbf084
Author: Patrick Monette <pmonette@chromium.org>
Date: Tue Jun 12 19:16:10 2018

Remove the conflicting module UI

This old UI is deprecated, and the replacement
(IncompatibleApplicationWarning feature) is already in place and being
experimented with.

Bug: 643532
Change-Id: Ia2ba7c072fcd2901dc0901f94650a153b8138426
Reviewed-on: https://chromium-review.googlesource.com/1091497
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566525}
[modify] https://crrev.com/66e935ac491542bde00638e1484ca2c5fdbbf084/chrome/app/chrome_command_ids.h
[modify] https://crrev.com/66e935ac491542bde00638e1484ca2c5fdbbf084/chrome/app/chromium_strings.grd
[modify] https://crrev.com/66e935ac491542bde00638e1484ca2c5fdbbf084/chrome/app/generated_resources.grd
[modify] https://crrev.com/66e935ac491542bde00638e1484ca2c5fdbbf084/chrome/app/google_chrome_strings.grd
[modify] https://crrev.com/66e935ac491542bde00638e1484ca2c5fdbbf084/chrome/app/resources/locale_settings.grd
[modify] https://crrev.com/66e935ac491542bde00638e1484ca2c5fdbbf084/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/66e935ac491542bde00638e1484ca2c5fdbbf084/chrome/browser/ui/browser_command_controller.cc
[modify] https://crrev.com/66e935ac491542bde00638e1484ca2c5fdbbf084/chrome/browser/ui/browser_dialogs.h
[modify] https://crrev.com/66e935ac491542bde00638e1484ca2c5fdbbf084/chrome/browser/ui/chrome_pages.cc
[modify] https://crrev.com/66e935ac491542bde00638e1484ca2c5fdbbf084/chrome/browser/ui/chrome_pages.h
[modify] https://crrev.com/66e935ac491542bde00638e1484ca2c5fdbbf084/chrome/browser/ui/cocoa/toolbar/app_toolbar_button.mm
[modify] https://crrev.com/66e935ac491542bde00638e1484ca2c5fdbbf084/chrome/browser/ui/toolbar/app_menu_icon_controller.cc
[modify] https://crrev.com/66e935ac491542bde00638e1484ca2c5fdbbf084/chrome/browser/ui/toolbar/app_menu_icon_controller.h
[modify] https://crrev.com/66e935ac491542bde00638e1484ca2c5fdbbf084/chrome/browser/ui/toolbar/app_menu_model.cc
[delete] https://crrev.com/843f4c596964746062da6786e6d4baac53720b3c/chrome/browser/ui/views/conflicting_module_view_win.cc
[delete] https://crrev.com/843f4c596964746062da6786e6d4baac53720b3c/chrome/browser/ui/views/conflicting_module_view_win.h
[modify] https://crrev.com/66e935ac491542bde00638e1484ca2c5fdbbf084/chrome/browser/ui/views/toolbar/browser_app_menu_button.cc
[modify] https://crrev.com/66e935ac491542bde00638e1484ca2c5fdbbf084/chrome/browser/ui/views/toolbar/toolbar_view.cc
[modify] https://crrev.com/66e935ac491542bde00638e1484ca2c5fdbbf084/tools/gritsettings/startup_resources_mac.txt
[modify] https://crrev.com/66e935ac491542bde00638e1484ca2c5fdbbf084/tools/metrics/actions/actions.xml
►

Sign in to add a comment