Histograms matching ProxyOverriddenBubble.* are unmapped |
||
Issue descriptionThe following histograms are present in Chromium source code but do not appear in histograms.xml. ProxyOverriddenBubble.ExtensionCount defined at chrome/browser/extensions/proxy_overridden_bubble_delegate.cc line 136 https://cs.chromium.org/chromium/src/chrome/browser/extensions/proxy_overridden_bubble_delegate.cc?l=136 ProxyOverriddenBubble.UserSelection defined at chrome/browser/extensions/proxy_overridden_bubble_delegate.cc line 141 https://cs.chromium.org/chromium/src/chrome/browser/extensions/proxy_overridden_bubble_delegate.cc?l=141 File and line information may be out-of-date by the time you read this. Please remove these histograms from the source code. If they were very recently added, it may be worth adding them to histograms.xml instead, but probably not. This bug was automatically assigned based on git blame information. If you are not the correct assignee for this bug, please delete the histograms anyway.
,
Sep 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8d7f62dfb5542efbd4ffeac6e7022a7d0bfb19dc commit 8d7f62dfb5542efbd4ffeac6e7022a7d0bfb19dc Author: rdevlin.cronin <rdevlin.cronin@chromium.org> Date: Fri Sep 09 15:19:32 2016 [Extensions] Add UMA for the proxy override bubble The proxy override bubble had some UMA entries, but they weren't present in histograms.xml. Add an entry and for the user action metric and add an obsolete entry (for historical reasons) for the extension count metric. BUG= 643531 Review-Url: https://codereview.chromium.org/2320013003 Cr-Commit-Position: refs/heads/master@{#417588} [modify] https://crrev.com/8d7f62dfb5542efbd4ffeac6e7022a7d0bfb19dc/chrome/browser/extensions/proxy_overridden_bubble_delegate.cc [modify] https://crrev.com/8d7f62dfb5542efbd4ffeac6e7022a7d0bfb19dc/tools/metrics/histograms/histograms.xml
,
Sep 9 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by finnur@chromium.org
, Sep 2 2016Owner: rdevlin....@chromium.org