New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 643528 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug
Team-Accessibility

Blocking:
issue 640921



Sign in to add a comment

Histograms matching Accessibility.* are unmapped

Project Member Reported by ricea@chromium.org, Sep 2 2016

Issue description

The following histograms are present in Chromium source code but do not
appear in histograms.xml.

Accessibility.FrameDidNotEnableCount defined at
content/browser/frame_host/render_frame_host_impl.cc line 2716
https://cs.chromium.org/chromium/src/content/browser/frame_host/render_frame_host_impl.cc?l=2716

Accessibility.FrameEnabledCount defined at
content/browser/frame_host/render_frame_host_impl.cc line 2714
https://cs.chromium.org/chromium/src/content/browser/frame_host/render_frame_host_impl.cc?l=2714

Accessibility.FrameResetCount defined at
content/browser/frame_host/render_frame_host_impl.cc line 738
https://cs.chromium.org/chromium/src/content/browser/frame_host/render_frame_host_impl.cc?l=738

File and line information may be out-of-date by the time you read this.

Please remove these histograms from the source code. If they were very
recently added, it may be worth adding them to histograms.xml instead, but
probably not.

This bug was automatically assigned based on git blame information. If you
are not the correct assignee for this bug, please delete the histograms
anyway.

 
Status: Started (was: Assigned)
https://codereview.chromium.org/2508623002/
Components: UI>Accessibility
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7060f6880c474039626ec52390b2e028a842886b

commit 7060f6880c474039626ec52390b2e028a842886b
Author: dmazzoni <dmazzoni@chromium.org>
Date: Wed Nov 16 06:47:14 2016

Remove unmapped histograms

BUG= 643528 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2508623002
Cr-Commit-Position: refs/heads/master@{#432410}

[modify] https://crrev.com/7060f6880c474039626ec52390b2e028a842886b/content/browser/frame_host/render_frame_host_impl.cc

Status: Fixed (was: Started)

Sign in to add a comment