New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 643527 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocking:
issue 640921



Sign in to add a comment

Histogram Download.DatabaseMainInsertError is unmapped

Project Member Reported by ricea@chromium.org, Sep 2 2016

Issue description

The histogram 'Download.DatabaseMainInsertError' is present in Chromium
source code but does not appear in histograms.xml. This means that data is
collected for the histogram but nothing useful is done with it.

The histogram was defined in
components/history/core/browser/download_database.cc at line 615.

https://cs.chromium.org/chromium/src/components/history/core/browser/download_database.cc?l=615

It may have moved by the time you read this.

Please remove the histogram 'Download.DatabaseMainInsertError' from the
source code. If it was very recently added, it may be worth adding it to
histograms.xml instead, but probably not.

This bug was automatically assigned based on git blame information. If you
are not the correct assignee for this bug, please delete the histogram
anyway.

 
Owner: sh...@chromium.org
Status: Assigned (was: Available)
Added by benjhayden but he doesn't work on Chrome any more, so ==>shess as reviewer of that change ( crrev.com/191678 )

Comment 2 by sh...@chromium.org, Jun 21 2017

Labels: ShessReview

Comment 3 by holte@chromium.org, Aug 22 2017

Components: -Internals>Metrics
Labels: Hotlist-Metrics

Comment 4 by jrobb...@google.com, Sep 21 2017

Owner: pwnall@chromium.org

Comment 5 by ricea@chromium.org, May 10 2018

This histogram has a comment "In order to save memory, take the general code, of which there are fewer than 50."

You could save even more memory by never recording it in the first place.

Sign in to add a comment