New issue
Advanced search Search tips

Issue 643526 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocking:
issue 640921



Sign in to add a comment

Histogram LevelDB.Open.UsageReportsBufferBackend is unmapped

Project Member Reported by ricea@chromium.org, Sep 2 2016

Issue description

The histogram 'LevelDB.Open.UsageReportsBufferBackend' is present in Chromium
source code but does not appear in histograms.xml. This means that data is
collected for the histogram but nothing useful is done with it.

The histogram was defined in
chrome/browser/android/history_report/usage_reports_buffer_backend.cc at line
42.

https://cs.chromium.org/chromium/src/chrome/browser/android/history_report/usage_reports_buffer_backend.cc?l=42

It may have moved by the time you read this.

Please remove the histogram 'LevelDB.Open.UsageReportsBufferBackend' from the
source code. If it was very recently added, it may be worth adding it to
histograms.xml instead, but probably not.

This bug was automatically assigned based on git blame information. If you
are not the correct assignee for this bug, please delete the histogram
anyway.

 

Comment 1 by holte@chromium.org, Aug 22 2017

Components: -Internals>Metrics
Labels: Hotlist-Metrics
Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e637e2d58827e3687dbfeecb4b5740bf7e9078ba

commit e637e2d58827e3687dbfeecb4b5740bf7e9078ba
Author: Chris Mumford <cmumford@chromium.org>
Date: Thu Oct 12 23:06:41 2017

leveldb: Fix suffix for LevelDBOpenResults UMA suffix.

Fix UMA histograms so that UMA statistics can be viewed.

According to 1db4a0bab64a the default suffix of '_' never matched
the logging code separator of '.' in leveldb_database.cc.

Bug:  643526 
Change-Id: I666acbe03d3ac3bcc2656851c098b91b0e7054b3
Reviewed-on: https://chromium-review.googlesource.com/714127
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Chris Mumford <cmumford@chromium.org>
Cr-Commit-Position: refs/heads/master@{#508524}
[modify] https://crrev.com/e637e2d58827e3687dbfeecb4b5740bf7e9078ba/tools/metrics/histograms/histograms.xml

Status: Fixed (was: Started)

Sign in to add a comment