Histogram Overscroll.ScreenshotSize is unmapped |
|
Issue descriptionThe histogram 'Overscroll.ScreenshotSize' is present in Chromium source code but does not appear in histograms.xml. This means that data is collected for the histogram but nothing useful is done with it. The histogram was defined in content/browser/frame_host/navigation_entry_impl.cc at line 890. https://cs.chromium.org/chromium/src/content/browser/frame_host/navigation_entry_impl.cc?l=890 It may have moved by the time you read this. Please remove the histogram 'Overscroll.ScreenshotSize' from the source code. If it was very recently added, it may be worth adding it to histograms.xml instead, but probably not. This bug was automatically assigned based on git blame information. If you are not the correct assignee for this bug, please delete the histogram anyway.
,
May 10 2018
If you remove the histogram, you can make SetScreenshotPNGData() inline. Also looks like it should be using std::move on png_data. |
|
►
Sign in to add a comment |
|
Comment 1 by holte@chromium.org
, Aug 22 2017Labels: Hotlist-Metrics