New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 643522 link

Starred by 1 user
Status: Fixed
Owner:
ccameron@chromium.org
Closed: Sep 2016
Cc:
skare@chromium.org
isherman@chromium.org
asvitk...@chromium.org
█ rkaplow@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocking:
issue 640921



Sign in to add a comment

Histograms matching GPU.* are unmapped

Project Member Reported by ricea@chromium.org, Sep 2 2016 
The following histograms are present in Chromium source code but do not
appear in histograms.xml.

GPU.AtExitContextGroupCount defined at
content/browser/gpu/gpu_process_host.cc line 497
https://cs.chromium.org/chromium/src/content/browser/gpu/gpu_process_host.cc?l=497

GPU.AtExitReceivedMemoryStats defined at
content/browser/gpu/gpu_process_host.cc line 493
https://cs.chromium.org/chromium/src/content/browser/gpu/gpu_process_host.cc?l=493

File and line information may be out-of-date by the time you read this.

Please remove these histograms from the source code. If they were very
recently added, it may be worth adding them to histograms.xml instead, but
probably not.

This bug was automatically assigned based on git blame information. If you
are not the correct assignee for this bug, please delete the histograms
anyway.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 8 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/da97274a9eaa10df5508e951d26c08e58ac38c23

commit da97274a9eaa10df5508e951d26c08e58ac38c23
Author: ccameron <ccameron@chromium.org>
Date: Thu Sep 08 09:14:49 2016

Remove GPU memory UMAs

Nobody is looking at them, and they're not even in histograms.xml

The only thing GpuMemoryManager is doing now is populating the task
manager values.

BUG= 643522 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2310623002
Cr-Commit-Position: refs/heads/master@{#417233}

[modify] https://crrev.com/da97274a9eaa10df5508e951d26c08e58ac38c23/content/browser/gpu/gpu_process_host.cc
[modify] https://crrev.com/da97274a9eaa10df5508e951d26c08e58ac38c23/content/browser/gpu/gpu_process_host.h
[modify] https://crrev.com/da97274a9eaa10df5508e951d26c08e58ac38c23/content/common/gpu_host_messages.h
[modify] https://crrev.com/da97274a9eaa10df5508e951d26c08e58ac38c23/content/gpu/gpu_child_thread.cc
[modify] https://crrev.com/da97274a9eaa10df5508e951d26c08e58ac38c23/content/gpu/gpu_child_thread.h
[modify] https://crrev.com/da97274a9eaa10df5508e951d26c08e58ac38c23/gpu/ipc/common/BUILD.gn
[delete] https://crrev.com/63707a419a116bfbafe9c7d9255a1bb8b538bf12/gpu/ipc/common/gpu_memory_uma_stats.h
[modify] https://crrev.com/da97274a9eaa10df5508e951d26c08e58ac38c23/gpu/ipc/common/memory_stats.cc
[modify] https://crrev.com/da97274a9eaa10df5508e951d26c08e58ac38c23/gpu/ipc/common/memory_stats.h
[modify] https://crrev.com/da97274a9eaa10df5508e951d26c08e58ac38c23/gpu/ipc/service/gpu_channel_manager_delegate.h
[modify] https://crrev.com/da97274a9eaa10df5508e951d26c08e58ac38c23/gpu/ipc/service/gpu_channel_test_common.cc
[modify] https://crrev.com/da97274a9eaa10df5508e951d26c08e58ac38c23/gpu/ipc/service/gpu_channel_test_common.h
[modify] https://crrev.com/da97274a9eaa10df5508e951d26c08e58ac38c23/gpu/ipc/service/gpu_memory_manager.cc
[modify] https://crrev.com/da97274a9eaa10df5508e951d26c08e58ac38c23/gpu/ipc/service/gpu_memory_manager.h
[modify] https://crrev.com/da97274a9eaa10df5508e951d26c08e58ac38c23/services/ui/gpu/gpu_service_internal.cc
[modify] https://crrev.com/da97274a9eaa10df5508e951d26c08e58ac38c23/services/ui/gpu/gpu_service_internal.h

Comment 2 by ricea@chromium.org, Sep 8 2016 

This is great! Thank you.

Comment 3 by ccameron@chromium.org, Sep 8 2016

Status: Fixed (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 8 2016

Labels: merge-merged-2854
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/da97274a9eaa10df5508e951d26c08e58ac38c23

commit da97274a9eaa10df5508e951d26c08e58ac38c23
Author: ccameron <ccameron@chromium.org>
Date: Thu Sep 08 09:14:49 2016

Remove GPU memory UMAs

Nobody is looking at them, and they're not even in histograms.xml

The only thing GpuMemoryManager is doing now is populating the task
manager values.

BUG= 643522 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2310623002
Cr-Commit-Position: refs/heads/master@{#417233}

[modify] https://crrev.com/da97274a9eaa10df5508e951d26c08e58ac38c23/content/browser/gpu/gpu_process_host.cc
[modify] https://crrev.com/da97274a9eaa10df5508e951d26c08e58ac38c23/content/browser/gpu/gpu_process_host.h
[modify] https://crrev.com/da97274a9eaa10df5508e951d26c08e58ac38c23/content/common/gpu_host_messages.h
[modify] https://crrev.com/da97274a9eaa10df5508e951d26c08e58ac38c23/content/gpu/gpu_child_thread.cc
[modify] https://crrev.com/da97274a9eaa10df5508e951d26c08e58ac38c23/content/gpu/gpu_child_thread.h
[modify] https://crrev.com/da97274a9eaa10df5508e951d26c08e58ac38c23/gpu/ipc/common/BUILD.gn
[delete] https://crrev.com/63707a419a116bfbafe9c7d9255a1bb8b538bf12/gpu/ipc/common/gpu_memory_uma_stats.h
[modify] https://crrev.com/da97274a9eaa10df5508e951d26c08e58ac38c23/gpu/ipc/common/memory_stats.cc
[modify] https://crrev.com/da97274a9eaa10df5508e951d26c08e58ac38c23/gpu/ipc/common/memory_stats.h
[modify] https://crrev.com/da97274a9eaa10df5508e951d26c08e58ac38c23/gpu/ipc/service/gpu_channel_manager_delegate.h
[modify] https://crrev.com/da97274a9eaa10df5508e951d26c08e58ac38c23/gpu/ipc/service/gpu_channel_test_common.cc
[modify] https://crrev.com/da97274a9eaa10df5508e951d26c08e58ac38c23/gpu/ipc/service/gpu_channel_test_common.h
[modify] https://crrev.com/da97274a9eaa10df5508e951d26c08e58ac38c23/gpu/ipc/service/gpu_memory_manager.cc
[modify] https://crrev.com/da97274a9eaa10df5508e951d26c08e58ac38c23/gpu/ipc/service/gpu_memory_manager.h
[modify] https://crrev.com/da97274a9eaa10df5508e951d26c08e58ac38c23/services/ui/gpu/gpu_service_internal.cc
[modify] https://crrev.com/da97274a9eaa10df5508e951d26c08e58ac38c23/services/ui/gpu/gpu_service_internal.h
►

Sign in to add a comment