New issue
Advanced search Search tips

Issue 643521 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocking:
issue 640921



Sign in to add a comment

Histogram LockScreen.BackgroundReady is unmapped

Project Member Reported by ricea@chromium.org, Sep 2 2016

Issue description

The histogram 'LockScreen.BackgroundReady' is present in Chromium source code
but does not appear in histograms.xml. This means that data is collected for
the histogram but nothing useful is done with it.

The histogram was defined in
chrome/browser/chromeos/login/lock/webui_screen_locker.cc at line 198.

https://cs.chromium.org/chromium/src/chrome/browser/chromeos/login/lock/webui_screen_locker.cc?l=198

It may have moved by the time you read this.

Please remove the histogram 'LockScreen.BackgroundReady' from the source
code. If it was very recently added, it may be worth adding it to
histograms.xml instead, but probably not.

This bug was automatically assigned based on git blame information. If you
are not the correct assignee for this bug, please delete the histogram
anyway.

 

Comment 1 by ricea@chromium.org, Apr 21 2017

Owner: jdufault@chromium.org
+jdufault as caitkp@ has never visited.

Comment 2 by holte@chromium.org, Aug 22 2017

Components: -Internals>Metrics
Labels: Hotlist-Metrics

Comment 3 by ricea@chromium.org, May 10 2018

There seems to be a OnLockBackgroundDisplayed() virtual method that only exists to record this unused metric, and is only implemented for webui and not views. It looks like it would be a considerable saving to remove it.
Cc: wzang@chromium.org zalcorn@chromium.org
Given it has never been reported I'll remove it.

Sign in to add a comment