Histograms matching Autofill.* are unmapped |
|||||||
Issue descriptionThe following histograms are present in Chromium source code but do not appear in histograms.xml. Autofill.KeyboardAccessoryButtonsIOS_ScreenReaderOff defined at components/autofill/core/browser/keyboard_accessory_metrics_logger.mm line 23 https://cs.chromium.org/chromium/src/components/autofill/core/browser/keyboard_accessory_metrics_logger.mm?l=23 Autofill.KeyboardAccessoryButtonsIOS_ScreenReaderOn defined at components/autofill/core/browser/keyboard_accessory_metrics_logger.mm line 19 https://cs.chromium.org/chromium/src/components/autofill/core/browser/keyboard_accessory_metrics_logger.mm?l=19 File and line information may be out-of-date by the time you read this. Please remove these histograms from the source code. If they were very recently added, it may be worth adding them to histograms.xml instead, but probably not. This bug was automatically assigned based on git blame information. If you are not the correct assignee for this bug, please delete the histograms anyway.
,
Sep 2 2016
bondd - Can you help me understand what happened here? You added AutofillKeyboardAccessoryButtonsIOS to histograms.xml in http://crrev.com/1312973002 but what's getting logged is Autofill.KeyboardAccessoryButtonsIOS_ScreenReaderOn and Autofill.KeyboardAccessoryButtonsIOS_ScreenReaderOff. Did you just forget to update histograms.xml to match when you introduced the ScreenReaderOn/Off variations? Or is it supposed to still work because one thing is a prefix of the others?
,
Sep 2 2016
Looking further, I'm pretty sure I just need to update histograms.xml to split the metric into 2 to match what's being logged. But if you could confirm that it wasn't your intent to just have one metric, it'd be comforting.
,
Sep 2 2016
Hi jdonnelly, it looks like maybe I meant to add a "histogram_suffixes" for ScreenReaderOn and ScreenReaderOff (see the top of histograms.xml for details of "histogram_suffixes"). But you are correct, it wasn't my intent to just have one metric. Splitting the metric into 2 to match what's being logged should be fine, as far as I can tell.
,
Sep 2 2016
If these metrics have been unused and unmissed for a year, would it be appropriate to remove them rather than to surface them in the dashboard?
,
Aug 22 2017
,
Aug 23 2017
isherman: even though nobody has noticed the lack of this metric I think it's still likely that at some point somebody will want to know the answer to the question it's trying to address.
,
Aug 23 2017
zkoch: do you by any chance remember why we thought we cared about whether the screen reader was on when recording usage of the buttons on the iOS autofill keyboard accessory? My inclination here is to remove the screen reader on/off dimension of this metric while still maintaining the recording of how often each of the buttons was used. Let me know what you think.
,
May 1 2018
,
May 1 2018
I don't have any insight to this at this point beyond the earlier comments I added.
,
May 10 2018
I can create a CL to remove the histograms if it would help.
,
May 10 2018
Sounds good |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by bondd@chromium.org
, Sep 2 2016