New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 643509 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Email to this user bounced
Closed: Sep 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 643030



Sign in to add a comment

CustomElements tests when an element`s state is set "failed"

Project Member Reported by davaajav@google.com, Sep 2 2016

Issue description

state-failed-create.html
state-failed-upgrade.html

Maybe also check for "failed" elements prototype?

 
Blocking: 643030
The same thing goes for create-element-inside-template.html

But this time we want to make sure that it is "undefined" not "failed".
Status: Started (was: Untriaged)
I think there is no problem with state-failed-create.html

I will take a look at other 2 files.
Project Member

Comment 4 by sheriffbot@chromium.org, Sep 2 2016

Labels: Hotlist-Google
Components: Blink>DOM
Project Member

Comment 7 by bugdroid1@chromium.org, Sep 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/44d4690c35729c1cfa0f6d78df1de3e5effdf871

commit 44d4690c35729c1cfa0f6d78df1de3e5effdf871
Author: davaajav <davaajav@google.com>
Date: Wed Sep 07 09:21:57 2016

CustomelElements: add prototype check for "failed" elements

There 2 possible ways to set an element`s state to "failed":
1. create the element for the token
   https://html.spec.whatwg.org/multipage/syntax.html#create-an-element-for-the-token
2. upgrade the element
   https://html.spec.whatwg.org/#concept-upgrade-an-element
According to the spec, "failed" element should implement HTMLUnknownElement
only while it is being created for the token, not while it is being upgraded.

Added prototype sanity check when an element is created inside a template.

BUG= 643509 

Review-Url: https://codereview.chromium.org/2313573002
Cr-Commit-Position: refs/heads/master@{#416886}

[modify] https://crrev.com/44d4690c35729c1cfa0f6d78df1de3e5effdf871/third_party/WebKit/LayoutTests/custom-elements/spec/create-element-inside-template.html
[modify] https://crrev.com/44d4690c35729c1cfa0f6d78df1de3e5effdf871/third_party/WebKit/LayoutTests/custom-elements/spec/state-failed-create.html
[add] https://crrev.com/44d4690c35729c1cfa0f6d78df1de3e5effdf871/third_party/WebKit/LayoutTests/custom-elements/spec/state-failed-upgrade-expected.txt
[modify] https://crrev.com/44d4690c35729c1cfa0f6d78df1de3e5effdf871/third_party/WebKit/LayoutTests/custom-elements/spec/state-failed-upgrade.html

Labels: -Pri-3 Pri-2
Owner: davaajav@google.com
Is there anything left to do here?
Status: Fixed (was: Started)
I think we can close it. 

Sign in to add a comment