New issue
Advanced search Search tips

Issue 643490 link

Starred by 0 users

Issue metadata

Status: WontFix
Owner: ----
Closed: Sep 24
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Make Rebaseline/NeedsManualRebaseline not conflict with Pass lines

Project Member Reported by qyears...@chromium.org, Sep 2 2016

Issue description

From the Blink Infra roadmap doc (https://docs.google.com/spreadsheets/d/1tO4cfhj_CtX-W8edIl6JD8qf0UWHVJyrzEJOun1I0J4/edit#gid=0)

The comment says that what's left to do here is to re-land https://codereview.chromium.org/1412533002 but with a fix for the rebaseliner to only remove NeedsRebaseline lines.

bugsnash@, is this still something that we want to do? Why do we want to do this?
 
Cc: ojan@chromium.org
Ojan explained to me that the reason we want to do this is "so that people can add NeedsRebaseline lines that conflict with other lines. But that's blocked because the actual rebaseline script strips all the lines for the test being rebaselined, not just the NeedsRebaseline/Rebaseline lines."

I believe we still want to do this.
Alright -- I think that this would become unnecessary if we turn down the rebaseline bot, which we should be able to do after people can rebaseline pending CLs from try jobs ( bug 474273 ).
Cc: bugsnash@chromium.org
Owner: ----
bugsnash@, OK to mark this as available for now?
Status: Available (was: Unconfirmed)
Note, in the future we'll want to encourage people not to use NeedsRebaseline, since it's possible to rebaseline using try jobs with `webkit-patch rebaseline-cl`.

Comment 6 by ojan@chromium.org, Mar 7 2017

Cc: -ojan@chromium.org
Summary: Make Rebaseline/NeedsManualRebaseline not conflict with Pass lines (was: Make Rebaseline/NeedsRebaseline/NeedsManualRebaseline not conflict with Pass lines.)
Project Member

Comment 8 by sheriffbot@chromium.org, Aug 15

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: -bugsnash@chromium.org
Status: WontFix (was: Untriaged)
Made obsolete by issue 621126, although that is still in progress.

Sign in to add a comment