New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 643476 link

Starred by 4 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Feature



Sign in to add a comment

Don't send notifications for a WebAPK when notifications are disabled

Project Member Reported by sbirch@chromium.org, Sep 2 2016

Issue description

Notifications have a permission listed in settings by default (since Android apps get them automatically.) We should be sure to respect if a user has blocked notifications from a WebAPK.

Xi, IIRC you worked on notification handling before so sending it over to you for now. Note though that this isn't needed for the preview.
 

Comment 1 by hanxi@chromium.org, Sep 2 2016

Even if Chrome distributes a notification to a WebAPK whose notification is disabled, Android will disable the notification to be shown on the notification panel. We could add more checks for not sending the notification, but the existing mechanism sounds good enough to WebAPK. What do you think? 
Ideally if the user disables push for this WebAPK we would reflect that in the developer observable permission (I.e. Change it to denied). Not sure how technically complex that is though.

Comment 3 by sbirch@chromium.org, Jan 18 2017

Blocking: -629181
I'm going to take this off blocking since they key bit (that they aren't set) is satisfied by Android not allowing us to send the notifications. Agree that it would be good to reflect this in the permission but not a blocker for v0.

Comment 4 by sbirch@chromium.org, Jan 18 2017

*that they aren't sent
Sam, is this bug still valid? I think that what we want to do for notifications has changed. I am unsure if we have any bugs for the new plan
Status: Assigned (was: Untriaged)

Comment 7 by peter@chromium.org, Jan 27 2017

Components: UI>Notifications
Labels: -Pri-2 Pri-3
Owner: ----
Status: Available (was: Assigned)
Lower priority and unassigning - this needs some UX feedback on how to reflect it given that we could only show notifications are disabled but not make them editable

Comment 9 by peter@chromium.org, Mar 23 2017

Cc: awdf@chromium.org rolfe@chromium.org
+Rebecca and Anita who have been thinking about this problem.

Comment 10 by rolfe@chromium.org, Mar 23 2017

Cc: chowse@chromium.org
+chowse as your WebAPK designer (and will take over notifications after 59 branch) but sbirch@ might be able to confirm no UX is needed at the moment (talked to him a bit informally about it.)

Comment 11 by awdf@chromium.org, Mar 24 2017

This is a similar problem to the one we face in Android O where we plan to soon allow users to allow/block web notifications from particular sites at a system level using notification channels - see https://bugs.chromium.org/p/chromium/issues/detail?id=700377 . We need to show the permission state but not make it editable - what we're planning on doing there is instead linking through to Android settings from the existing UI when the user tries to toggle. I wonder if we could do a similar thing for Web APKs on all versions of Android.

Comment 12 by rolfe@chromium.org, Mar 24 2017

Mocks for that if it's helpful:
https://folio.googleplex.com/chrome-ux/mocks/428-o-notifications/032317_Flow#%2F01_Comparison.png%3Fz=width

I'm having trouble picturing where in the WebAPK that notifications are disabled and not editable (I thought they'd be like an installed app and have notifications permissions listed in their app info page.)

Comment 13 by awdf@chromium.org, Mar 27 2017

I was talking about the notification permissions listed within Chrome's in-app site settings in #11 - indeed they would be editable from the web apk's system settings, I'd need to check whether we can link the user through to those from Chrome's in-app settings though.

Comment 14 by rolfe@chromium.org, Mar 27 2017

I might not be up on the latest, but I believe once you install a WebAPK, the site you installed it from continues to exists separately. The permissions between the two can be different, and editable individually. This leads to messiness if you change permissions in one spot but not the other, but at least both are still editable.

sbirch - is that correct or am I out-of-date there?

Comment 15 by rolfe@chromium.org, Mar 30 2017

Cc: -rolfe@chromium.org
Removing myself and letting chowse@ take it from here!
Project Member

Comment 16 by sheriffbot@chromium.org, Apr 11 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Available (was: Untriaged)

Sign in to add a comment