Notification prompts disk format even when ExternalDeviceReadOnly policy is set |
||||||||
Issue descriptionChrome OS Version: ToT Steps To Reproduce: (1) Set policy: ExternalStorageReadOnly = true, ExternalStorageDisabled = false (2) Insert an unformatted USB drive. (3) See the notification message popping up on the right-bottom of the screen. Expected Result: - The system should not prompt the user to format the disk - It should notify it’s not readable because it's unformatted. Actual Result: - It says "Removable device detected Explore the device content in the Files app.", which is same message as when ExternalStorageReadOnly=false. How frequently does this problem reproduce? (Always, sometimes, hard to reproduce?) Always What is the impact to the user, and is there a workaround? If so, what is it? Users will end up finding the drive is not formatted (and cannot format it because of the policy). Users cannot actually explore the files in it after opening Files app. It's harmless, but not correct. It'd be much better if user can know it without opening the files app.
,
Sep 2 2016
The message currently shown in this situation is "Sorry, at least one partition on your external storage device could not be mounted." (At least when ExternalStorageReadOnly=false). https://cs.chromium.org/chromium/src/chrome/app/chromeos_strings.grdp?q=%22Sorry,+at+least+one+partition+on+your+external+storage+device+could+not+be+mounted%22&sq=package:chromium&l=4033&dr=C
,
Sep 2 2016
So far I have heard of 2 cases. - unformatted disk recognized as unmountable (like the screenshot above) - unformatted disk recognized as if it's formatted The latter requires more investigation. This bug will focus on the former. "Format this device" link in the notification should be removed when the read-only policy is applied.
,
Sep 2 2016
,
Sep 5 2016
,
Sep 8 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/01d0c324611df6ceb900aae7766bc15517eb9bca commit 01d0c324611df6ceb900aae7766bc15517eb9bca Author: yamaguchi <yamaguchi@chromium.org> Date: Thu Sep 08 05:44:44 2016 Hide "Format device" button in notification of unknown device when it is read only. BUG= 644043 , 643475 NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2310783004 Cr-Commit-Position: refs/heads/master@{#416576} (cherry picked from commit 5c3efcf062d49a2585fc3be33286e91118cd7efc) Review-Url: https://codereview.chromium.org/2319603002 Cr-Commit-Position: refs/branch-heads/2840@{#228} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/01d0c324611df6ceb900aae7766bc15517eb9bca/ui/file_manager/file_manager/background/js/device_handler.js [modify] https://crrev.com/01d0c324611df6ceb900aae7766bc15517eb9bca/ui/file_manager/file_manager/background/js/device_handler_unittest.js
,
Sep 8 2016
,
Oct 3 2016
,
Oct 3 2016
,
Oct 25 2016
Verified. M54-BETA-CHROMEOS-7 (8743.74.0, 54.0.2840.77) Device: Stout PVT Server: DM server
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/01d0c324611df6ceb900aae7766bc15517eb9bca commit 01d0c324611df6ceb900aae7766bc15517eb9bca Author: yamaguchi <yamaguchi@chromium.org> Date: Thu Sep 08 05:44:44 2016 Hide "Format device" button in notification of unknown device when it is read only. BUG= 644043 , 643475 NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2310783004 Cr-Commit-Position: refs/heads/master@{#416576} (cherry picked from commit 5c3efcf062d49a2585fc3be33286e91118cd7efc) Review-Url: https://codereview.chromium.org/2319603002 Cr-Commit-Position: refs/branch-heads/2840@{#228} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/01d0c324611df6ceb900aae7766bc15517eb9bca/ui/file_manager/file_manager/background/js/device_handler.js [modify] https://crrev.com/01d0c324611df6ceb900aae7766bc15517eb9bca/ui/file_manager/file_manager/background/js/device_handler_unittest.js |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by yamaguchi@chromium.org
, Sep 2 2016