New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 643470 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

"Locally defined symbol imported" while linking cloud_policy_generated.obj

Project Member Reported by pkasting@chromium.org, Sep 2 2016

Issue description

I've recently been getting these build warnings with MSVC.

Brett, could this have been due to https://chromium.googlesource.com/chromium/src/+/39d6ba4eece90cc70bff87f2ecc39e5a790e1233 ?  That seems like a plausible recent culprit.

generated.lib(cloud_policy_generated.obj) : warning LNK4217: locally defined symbol ??1ExternalDataFetcher@policy@@QEAA@XZ (public: __cdecl policy::ExternalDataFetcher::~ExternalDataFetcher(void)) imported in function "public: void * __cdecl policy::ExternalDataFetcher::`scalar deleting destructor'(unsigned int)" (??_GExternalDataFetcher@policy@@QEAAPEAXI@Z)

generated.lib(cloud_policy_generated.obj) : warning LNK4217: locally defined symbol ?Set@PolicyMap@policy@@QEAAXAEBV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@W4PolicyLevel@2@W4PolicyScope@2@W4PolicySource@2@V?$unique_ptr@VValue@base@@U?$default_delete@VValue@base@@@std@@@4@V?$unique_ptr@VExternalDataFetcher@policy@@U?$default_delete@VExternalDataFetcher@policy@@@std@@@4@@Z (public: void __cdecl policy::PolicyMap::Set(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,enum policy::PolicyLevel,enum policy::PolicyScope,enum policy::PolicySource,class std::unique_ptr<class
base::Value,struct std::default_delete<class base::Value> >,class std::unique_ptr<class policy::ExternalDataFetcher,struct std::default_delete<class policy::ExternalDataFetcher> >)) imported in function "void __cdecl policy::DecodePolicy(class enterprise_management::CloudPolicySettings const &,class base::WeakPtr<class policy::CloudExternalDataManager>,class policy::PolicyMap *)" (?DecodePolicy@policy@@YAXAEBVCloudPolicySettings@enterprise_management@@V?$WeakPtr@VCloudExternalDataManager@policy@@@base@@PEAVPolicyMap@1@@Z)


 

Comment 1 by wfh@chromium.org, Sep 12 2016

Cc: dcheng@chromium.org wfh@chromium.org
getting same thing. am at rev 11264b0d

could this also be https://codereview.chromium.org/1940153002

Comment 2 by wfh@chromium.org, Sep 19 2016

Still happening for me. I am at git rev 03f3d50ebcc6ed52ef450846d882e35f3dc3d12f and my gn args are:

is_component_build = true
is_debug = false
target_cpu = "x86"
enable_nacl = false
remove_webcore_debug_symbols = true
is_chrome_branded = true
is_clang = true


Comment 3 by dcheng@chromium.org, Sep 21 2016

Cc: -dcheng@chromium.org brettw@chromium.org
Owner: dcheng@chromium.org
Status: Assigned (was: Untriaged)
I'm pretty sure this is the source move. But since I've been having so much fun with GN, I think I have an idea of how to fix this one.
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2deedf078fe607d4f8d2823c3ca9ef8449558785

commit 2deedf078fe607d4f8d2823c3ca9ef8449558785
Author: dcheng <dcheng@chromium.org>
Date: Thu Sep 22 15:08:46 2016

Fix Windows linker warning in components/policy/generated.lib

BUG= 643470 

Review-Url: https://codereview.chromium.org/2359033002
Cr-Commit-Position: refs/heads/master@{#420343}

[modify] https://crrev.com/2deedf078fe607d4f8d2823c3ca9ef8449558785/components/policy/BUILD.gn

Comment 5 by wfh@chromium.org, Sep 22 2016

Status: Fixed (was: Assigned)
I verified that this CL removed the warning, so marking as Fixed.

Sign in to add a comment