Android CTS verifier "Insecure service" test failure |
|||||||||||||||||||
Issue descriptionAndroid CTS verifier "Insure server/client" tests do not pass currently. For the insecure server test, We fixed the crashes with the following patches: These Chrome patches need to be merged into M53. - http://crrev.com/2149713002 (open) arc: bluetooth: Add SDP host side support - http://crrev.com/2302963002 (open) device/bluetooth: Add a helper function to BluetoothServiceRecordBlueZ - http://crrev.com/2288823003 (closed) device/bluetooth: Fix Interger type for DBus message construction - http://crrev.com/2284713002 (closed) device/bluetooth: Fix copy constructor of BluetoothServiceAttributeValueBlueZ - http://crrev.com/2287023002 (closed) device/bluetooth: Fix = operator and copy constructor of BluetoothServiceAttributeValueBlueZ - http://crrev.com/2284183002 (closed) device/bluetooth: Fix DBus message construction of CreateServiceRecord method These BlueZ patches need to be merge into M53. - https://chromium-review.googlesource.com/377743 CHROMIUM: Add pattern list to the SDP record created via CreatServiceRecord - https://chromium-review.googlesource.com/377440 CHROMIUM: Fix the crash caused by memory release
,
Sep 7 2016
Ask Bernie to merge review. This CL touches only components/arc - http://crrev.com/2149713002 arc: bluetooth: Add SDP host side support These CLs fix the new feature in M53 that is specific to ARC in device/bluetooth/bluez - http://crrev.com/2302963002 device/bluetooth: Add a helper function to BluetoothServiceRecordBlueZ - http://crrev.com/2288823003 device/bluetooth: Fix Interger type for DBus message construction - http://crrev.com/2284713002 device/bluetooth: Fix copy constructor of BluetoothServiceAttributeValueBlueZ - http://crrev.com/2287023002 device/bluetooth: Fix = operator and copy constructor of BluetoothServiceAttributeValueBlueZ - http://crrev.com/2284183002 device/bluetooth: Fix DBus message construction of CreateServiceRecord method These CLs fix the new feature in M53 that is specific to ARC in chromeos/third_party/bluez - https://chromium-review.googlesource.com/377743 CHROMIUM: Add pattern list to the SDP record created via CreatServiceRecord - https://chromium-review.googlesource.com/377440 CHROMIUM: Fix the crash caused by memory release
,
Sep 8 2016
Hello Bernie, All the patches are ready for merging back to M53, can you help with the merge request? Thanks.
,
Sep 8 2016
These changes touch a lot of code outside of ARC, we are getting super late in the R53 cycle to take such changes. Is there any way we can still function in R53 without making changes to the generic BT code for the rest of the OS? We can land these in R54 though, so we should at least start with that.
,
Sep 8 2016
Unfortunately, these patches are mandatory for the SDP and RFCOMM support in M53. All the changes that we made outside of ARC is specific to SDP of BlueZ, so no other platforms will be affected by these changes. And ARC SDP will be the only user of the touched Chrome APIs.
,
Sep 8 2016
[Automated comment] Request affecting a post-stable build (M53), manual review required.
,
Sep 8 2016
Thanks for the clarification, merge at your convenience.
,
Sep 8 2016
Thanks for pushing this.
,
Sep 8 2016
Here is an add-on CL which I forgot to add. This CL fixes the new feature in M53 that is specific to ARC in device/bluetooth/bluez. This CL is already in M54, so it only needs to be merged back to M53. - https://codereview.chromium.org/2254973006/ device/bluetooth: Add a constructor to BluetoothServiceAttributeValueBlueZ
,
Sep 9 2016
Add-on fix on Chrome OS BlueZ: https://chromium-review.googlesource.com/#/c/382831
,
Sep 10 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/bluez/+/a28df592c4e22c0d68f000766001f6e419519112 commit a28df592c4e22c0d68f000766001f6e419519112 Author: Miao Chou <mcchou@chromium.org> Date: Thu Sep 08 00:46:51 2016 CHROMIUM: Add SDP records retrieval for a unpaired/unconnected device This add the support of SDP record inquiry to a device which is not paired or connected previously. BUG= chromium:643445 ,b:30507946 TEST=verify the structures of records by calling GetServiceRecords() Change-Id: Id43ae615f12f114524841116f2790df609a2fc65 Reviewed-on: https://chromium-review.googlesource.com/382831 Commit-Ready: Miao-chen Chou <mcchou@chromium.org> Tested-by: Puthikorn Voravootivat <puthik@chromium.org> Tested-by: Miao-chen Chou <mcchou@chromium.org> Reviewed-by: Puthikorn Voravootivat <puthik@chromium.org> Reviewed-by: Rahul Chaturvedi <rkc@chromium.org> Reviewed-by: Miao-chen Chou <mcchou@chromium.org> [modify] https://crrev.com/a28df592c4e22c0d68f000766001f6e419519112/src/device.c
,
Sep 10 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/bluez/+/ec4899e3ed893dba90f4272b81d111b5568982e1 commit ec4899e3ed893dba90f4272b81d111b5568982e1 Author: Miao Chou <mcchou@chromium.org> Date: Thu Sep 08 00:46:51 2016 CHROMIUM: Add SDP records retrieval for a unpaired/unconnected device This add the support of SDP record inquiry to a device which is not paired or connected previously. BUG= chromium:643445 ,b:30507946 TEST=verify the structures of records by calling GetServiceRecords() Change-Id: Id43ae615f12f114524841116f2790df609a2fc65 Reviewed-on: https://chromium-review.googlesource.com/382831 Commit-Ready: Miao-chen Chou <mcchou@chromium.org> Tested-by: Puthikorn Voravootivat <puthik@chromium.org> Tested-by: Miao-chen Chou <mcchou@chromium.org> Reviewed-by: Puthikorn Voravootivat <puthik@chromium.org> Reviewed-by: Rahul Chaturvedi <rkc@chromium.org> Reviewed-by: Miao-chen Chou <mcchou@chromium.org> (cherry picked from commit a28df592c4e22c0d68f000766001f6e419519112) Reviewed-on: https://chromium-review.googlesource.com/383839 Commit-Queue: Miao-chen Chou <mcchou@chromium.org> Trybot-Ready: Miao-chen Chou <mcchou@chromium.org> [modify] https://crrev.com/ec4899e3ed893dba90f4272b81d111b5568982e1/src/device.c
,
Sep 10 2016
The following patches cherry-pick https://chromium-review.googlesource.com/#/c/382831 to M53 and M54: https://chromium-review.googlesource.com/#/c/383839/ https://chromium-review.googlesource.com/#/c/383840/
,
Sep 10 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/bluez/+/ec4899e3ed893dba90f4272b81d111b5568982e1 commit ec4899e3ed893dba90f4272b81d111b5568982e1 Author: Miao Chou <mcchou@chromium.org> Date: Thu Sep 08 00:46:51 2016 CHROMIUM: Add SDP records retrieval for a unpaired/unconnected device This add the support of SDP record inquiry to a device which is not paired or connected previously. BUG= chromium:643445 ,b:30507946 TEST=verify the structures of records by calling GetServiceRecords() Change-Id: Id43ae615f12f114524841116f2790df609a2fc65 Reviewed-on: https://chromium-review.googlesource.com/382831 Commit-Ready: Miao-chen Chou <mcchou@chromium.org> Tested-by: Puthikorn Voravootivat <puthik@chromium.org> Tested-by: Miao-chen Chou <mcchou@chromium.org> Reviewed-by: Puthikorn Voravootivat <puthik@chromium.org> Reviewed-by: Rahul Chaturvedi <rkc@chromium.org> Reviewed-by: Miao-chen Chou <mcchou@chromium.org> (cherry picked from commit a28df592c4e22c0d68f000766001f6e419519112) Reviewed-on: https://chromium-review.googlesource.com/383839 Commit-Queue: Miao-chen Chou <mcchou@chromium.org> Trybot-Ready: Miao-chen Chou <mcchou@chromium.org> [modify] https://crrev.com/ec4899e3ed893dba90f4272b81d111b5568982e1/src/device.c
,
Sep 10 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/bluez/+/bda635c54048bfc66e2c79506bff0790130fb8bc commit bda635c54048bfc66e2c79506bff0790130fb8bc Author: Miao Chou <mcchou@chromium.org> Date: Thu Sep 08 00:46:51 2016 CHROMIUM: Add SDP records retrieval for a unpaired/unconnected device This add the support of SDP record inquiry to a device which is not paired or connected previously. BUG= chromium:643445 ,b:30507946 TEST=verify the structures of records by calling GetServiceRecords() Change-Id: Id43ae615f12f114524841116f2790df609a2fc65 Reviewed-on: https://chromium-review.googlesource.com/382831 Commit-Ready: Miao-chen Chou <mcchou@chromium.org> Tested-by: Puthikorn Voravootivat <puthik@chromium.org> Tested-by: Miao-chen Chou <mcchou@chromium.org> Reviewed-by: Puthikorn Voravootivat <puthik@chromium.org> Reviewed-by: Rahul Chaturvedi <rkc@chromium.org> Reviewed-by: Miao-chen Chou <mcchou@chromium.org> (cherry picked from commit a28df592c4e22c0d68f000766001f6e419519112) Reviewed-on: https://chromium-review.googlesource.com/383840 Commit-Queue: Miao-chen Chou <mcchou@chromium.org> Trybot-Ready: Miao-chen Chou <mcchou@chromium.org> [modify] https://crrev.com/bda635c54048bfc66e2c79506bff0790130fb8bc/src/device.c
,
Sep 12 2016
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 12 2016
,
Sep 12 2016
Re open. Miao forgot to merge a patch in M53. (M54 has all patches merged) Assign to steel to help merge the following patch. http://crrev.com/702552c arc: bluetooth: Add SDP host side support This implements the Chrome side support for Service Discovery Protocol. - Retrieve SDP records from a remote device - Create/remove a SDP record for the local device - Convert service record/attribute between Chrome and Mojo BUG=b:29314637 TEST=None (The manual test is blocked on chromium:627907.) Review-Url: https://codereview.chromium.org/2149713002 Cr-Commit-Position: refs/heads/master@{#417210}
,
Sep 12 2016
This CL has some fairly large merge failures. Since she knows this code best, Miao should merge this.
,
Sep 12 2016
I resolved conflict and merge it here but need lgtm from committer http://crrev.com/2337783002
,
Sep 12 2016
#21 CL is merged
,
Sep 13 2016
,
Sep 14 2016
Apparently. The merge in #21 caused build break in M53. (Work fine in M54) This is fixed in Issue 646683
,
Sep 28 2016
,
Oct 4 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/bluez/+/e0eda713dde1d21bb222d51e2870cda733f5e35e commit e0eda713dde1d21bb222d51e2870cda733f5e35e Author: Miao Chou <mcchou@chromium.org> Date: Thu Sep 08 00:46:51 2016 CHROMIUM: Add SDP records retrieval for a unpaired/unconnected device This add the support of SDP record inquiry to a device which is not paired or connected previously. BUG= chromium:643445 ,b:30507946 TEST=verify the structures of records by calling GetServiceRecords() Old-Change-Id: Id43ae615f12f114524841116f2790df609a2fc65 Change-Id: I894f0fed4ac938b062870d675964a57b3d2f4075 Reviewed-on: https://chromium-review.googlesource.com/392113 Reviewed-by: Shyh-In Hwang <josephsih@chromium.org> Reviewed-by: Miao-chen Chou <mcchou@chromium.org> Commit-Queue: Miao-chen Chou <mcchou@chromium.org> Tested-by: Miao-chen Chou <mcchou@chromium.org> Trybot-Ready: Miao-chen Chou <mcchou@chromium.org> [modify] https://crrev.com/e0eda713dde1d21bb222d51e2870cda733f5e35e/src/device.c
,
Apr 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/bluez/+/184875d09d700b9a851d7dd946c060f856984234 commit 184875d09d700b9a851d7dd946c060f856984234 Author: Miao Chou <mcchou@chromium.org> Date: Wed Apr 19 07:15:40 2017 CHROMIUM: Add SDP records retrieval for a unpaired/unconnected device This add the support of SDP record inquiry to a device which is not paired or connected previously. BUG= chromium:643445 ,b:30507946 TEST=verify the structures of records by calling GetServiceRecords() Old-Change-Id: I894f0fed4ac938b062870d675964a57b3d2f4075 Change-Id: I73d6753544512a364fb1c340ce340e19f171f63c Reviewed-on: https://chromium-review.googlesource.com/469430 Reviewed-by: Rahul Chaturvedi <rkc@chromium.org> Tested-by: Miao-chen Chou <mcchou@chromium.org> Commit-Queue: Miao-chen Chou <mcchou@chromium.org> Trybot-Ready: Miao-chen Chou <mcchou@chromium.org> [modify] https://crrev.com/184875d09d700b9a851d7dd946c060f856984234/src/device.c
,
Apr 19 2017
|
|||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||
Comment 1 by puthik@chromium.org
, Sep 7 2016Labels: -M-54 -Merge-Rejected-53 Merge-Request-53 M-53
Owner: keta...@chromium.org