New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 643441 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

Data race in media::FFmpegDemuxer::~FFmpegDemuxer

Project Member Reported by ClusterFuzz, Sep 1 2016

Issue description

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=4781003317182464

Fuzzer: inferno_flicker
Job Type: linux_tsan_chrome_mp
Platform Id: linux

Crash Type: Data race WRITE 8
Crash Address: 0x7d4c00004600
Crash State:
  media::FFmpegDemuxer::~FFmpegDemuxer
  media::WebMediaPlayerImpl::~WebMediaPlayerImpl
  blink::HTMLMediaElement::invokeLoadAlgorithm
  
Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_tsan_chrome_mp&range=415049:415582

Minimized Testcase (1234.38 Kb): https://cluster-fuzz.appspot.com/download/AMIfv95iR8_jG-ia7mizHUOsjmKTxYuuMKk54Uq8slJ_vueotBuBBNTf9E2Ip4ShvMmKbzK1DPvjkm0PS4LYGlq9Hy3_YHnrK-lgQ4rxPb6RzY7exAQqmEQ8YNys8dfTeXkrROSXc7_0dDypuVsWLSoDYaWhP2zBhxqDvEw9QBl3pIynNMNyosk?testcase_id=4781003317182464

Issue manually filed by: mummareddy

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
 
Components: Internals>Media
Labels: Findit-for-crash M-55 Te-Logged
Owner: dalecur...@chromium.org
Status: Assigned (was: Untriaged)

The result is a list of CLs that change the crashed files.

Author: dalecurtis
Project: chromium
Changelist: https://chromium.googlesource.com/chromium/src/+/f299e19db62058180acf4276540670a90ff7b472
Time: Tue Aug 30 19:54:19 2016
Lines 901-916 of file ffmpeg_demuxer.cc which potentially caused crash are changed in this cl (frame #1, "media::FFmpegDemuxer::AbortPendingReads").
Minimum distance from crash line to modified line: 0. (file: ffmpeg_demuxer.cc, crashed on: 898, modified: 898).

Suspected Project: chromium
Status: Started (was: Assigned)
Project Member

Comment 3 by ClusterFuzz, Sep 2 2016

ClusterFuzz has detected this issue as fixed in range 415740:415887.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=4781003317182464

Fuzzer: inferno_flicker
Job Type: linux_tsan_chrome_mp
Platform Id: linux

Crash Type: Data race WRITE 8
Crash Address: 0x7d4c00004600
Crash State:
  media::FFmpegDemuxer::~FFmpegDemuxer
  media::WebMediaPlayerImpl::~WebMediaPlayerImpl
  blink::HTMLMediaElement::invokeLoadAlgorithm
  
Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_tsan_chrome_mp&range=415049:415582
Fixed: https://cluster-fuzz.appspot.com/revisions?job=linux_tsan_chrome_mp&range=415740:415887

Minimized Testcase (1234.38 Kb): https://cluster-fuzz.appspot.com/download/AMIfv95iR8_jG-ia7mizHUOsjmKTxYuuMKk54Uq8slJ_vueotBuBBNTf9E2Ip4ShvMmKbzK1DPvjkm0PS4LYGlq9Hy3_YHnrK-lgQ4rxPb6RzY7exAQqmEQ8YNys8dfTeXkrROSXc7_0dDypuVsWLSoDYaWhP2zBhxqDvEw9QBl3pIynNMNyosk?testcase_id=4781003317182464

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 4 by ClusterFuzz, Sep 2 2016

Labels: ClusterFuzz-Verified
Status: Verified (was: Started)
ClusterFuzz testcase is verified as fixed, closing issue.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a6912725c190eebf472d78a44d8fd247751e9a07

commit a6912725c190eebf472d78a44d8fd247751e9a07
Author: dalecurtis <dalecurtis@chromium.org>
Date: Sat Sep 03 02:29:24 2016

Ensure FFmpegDemuxer WeakPtrs are created on the right thread.

CancelPendingSeek() was called from the render thread, but the
WeakFactory in FFmpegDemuxer is for use on the media thread.

BUG= 643441 
TEST=none

Review-Url: https://codereview.chromium.org/2305923002
Cr-Commit-Position: refs/heads/master@{#416426}

[modify] https://crrev.com/a6912725c190eebf472d78a44d8fd247751e9a07/media/filters/ffmpeg_demuxer.cc
[modify] https://crrev.com/a6912725c190eebf472d78a44d8fd247751e9a07/media/filters/ffmpeg_demuxer.h

Project Member

Comment 6 by sheriffbot@chromium.org, Nov 22 2016

Labels: -Restrict-View-EditIssue
Removing EditIssue view restrictions from ClusterFuzz filed bugs. If you believe that this issue should still be restricted, please reapply the label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment