New issue
Advanced search Search tips

Issue 643426 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 646176



Sign in to add a comment

Fix LocalBorderBoxProperties to always be present when need in paint invalidation

Project Member Reported by chrishtr@chromium.org, Sep 1 2016

Issue description

Right now it's only present if isBox() or hasLayer() is true.
 
Blocking: -471333 646176
Owner: wangxianzhu@chromium.org
Chris, can you explain more the reason? For now paint invalidation seems to work fine without this bug fixed.
I think the reason was to be able to compute invalidation rects with GeometryMapper for
non-boxes/layers. How is that done without this?
Status: WontFix (was: Assigned)
We don't use localBorderBoxProperties, but PaintPropertyTreeBuilderContext, for paint offset and property tree state of the current object, like the following:

    rect.moveBy(FloatPoint(context.treeBuilderContext.current.paintOffset));
    PropertyTreeState currentTreeState(
        context.treeBuilderContext.current.transform,
        context.treeBuilderContext.current.clip,
        context.treeBuilderContext.currentEffect,
        context.treeBuilderContext.current.scroll);

We do need localBorderBoxProperties for paint offset and property tree state of the paint invalidation container which always has localBorderBoxProperties.

Right, thanks for reminding me. Agreed!

Sign in to add a comment