Fix LocalBorderBoxProperties to always be present when need in paint invalidation |
||
Issue descriptionRight now it's only present if isBox() or hasLayer() is true.
,
Dec 28 2016
Chris, can you explain more the reason? For now paint invalidation seems to work fine without this bug fixed.
,
Dec 28 2016
I think the reason was to be able to compute invalidation rects with GeometryMapper for non-boxes/layers. How is that done without this?
,
Dec 28 2016
We don't use localBorderBoxProperties, but PaintPropertyTreeBuilderContext, for paint offset and property tree state of the current object, like the following:
rect.moveBy(FloatPoint(context.treeBuilderContext.current.paintOffset));
PropertyTreeState currentTreeState(
context.treeBuilderContext.current.transform,
context.treeBuilderContext.current.clip,
context.treeBuilderContext.currentEffect,
context.treeBuilderContext.current.scroll);
We do need localBorderBoxProperties for paint offset and property tree state of the paint invalidation container which always has localBorderBoxProperties.
,
Dec 28 2016
Right, thanks for reminding me. Agreed! |
||
►
Sign in to add a comment |
||
Comment 1 by chrishtr@chromium.org
, Dec 20 2016Owner: wangxianzhu@chromium.org