alerts-dispatcher should hit build.chromium.org much less, or not at all |
||||
Issue description
,
Sep 1 2016
,
Sep 1 2016
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra.git/+/fe85873aebdd91aeeb0e34a32fa04c4e5cf6a266 commit fe85873aebdd91aeeb0e34a32fa04c4e5cf6a266 Author: Stephen Martinis <martiniss@chromium.org> Date: Thu Sep 01 23:10:11 2016 AD: poll CBE for build json Note that this will slow down any tree which has internal masters. CBE has only public master data, so every request to it will fail, and then get retried with direct polling, which we already do for internal masters (and are fine with). This should change eventually. BUG= 643422 Change-Id: I761be979b1a4a2acded560e1355be06e031bb8d7 Reviewed-on: https://chromium-review.googlesource.com/380411 Reviewed-by: Sean McCullough <seanmccullough@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> [modify] https://crrev.com/fe85873aebdd91aeeb0e34a32fa04c4e5cf6a266/go/src/infra/monitoring/client/client.go [modify] https://crrev.com/fe85873aebdd91aeeb0e34a32fa04c4e5cf6a266/go/src/infra/monitoring/messages/gatekeeper.go
,
Sep 1 2016
Tried deploying the above change, it seemed to have broken stuff :(
,
Sep 2 2016
"The web-page 'stop build' button was pressed by '<unknown>': <no reason specified>" Was that you cancelling it?
,
Sep 2 2016
Yes, I stopped the builds a couple times. The current build running is what was running before the CL in #3 landed. I can't reproduce on my local machine.... :(
,
Sep 2 2016
"Error decoding response: json: cannot unmarshal number into Go value of type messages.Build" might be a clue...
,
Sep 2 2016
I checked that out. That's a 500 in CBE, for some random reason. Could that be making it stop looking for builds or something? :(
,
Sep 2 2016
For a lot of these buildbot URLs, the corresponding CBE url returns a 404. I think it just doesn't have the build information. The URL pattern is correct, because sometimes it does work, e.g. https://chrome-build-extract.appspot.com/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/15819?json=1 I think CBE is just waaaay behind. I disabled the masterURL.Internal() checks (boooo) and it generated alerts again.
,
Sep 2 2016
,
Sep 2 2016
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra.git/+/6808195c8984f76c0aad2f9d06c378f9e76f153b commit 6808195c8984f76c0aad2f9d06c378f9e76f153b Author: Sean McCullough <seanmccullough@chromium.org> Date: Fri Sep 02 19:57:55 2016 [alerts-dispatcher] Query builders when CBE 404s BUG= 643422 Change-Id: I0d12bacaf309b72def16ce2b09c6396e5321bb73 Reviewed-on: https://chromium-review.googlesource.com/380378 Commit-Queue: Sean McCullough <seanmccullough@chromium.org> Reviewed-by: Stephen Martinis <martiniss@chromium.org> [modify] https://crrev.com/6808195c8984f76c0aad2f9d06c378f9e76f153b/go/src/infra/monitoring/client/client.go
,
Sep 6 2016
Any update on this?
,
Sep 6 2016
It's only hitting builders when CBE 404s now, which IIRC is equivalent to what builder-alerts does. Closing. |
||||
►
Sign in to add a comment |
||||
Comment 1 by martiniss@chromium.org
, Sep 1 2016Status: Started (was: Available)