ui/views/BUILD.gn relies on use_atk to build with X11 |
||
Issue descriptionFrom ui/views/BUILD.gn (https://cs.chromium.org/chromium/src/ui/views/BUILD.gn?rcl=0&l=556) if (!is_chromeos) { ... if (use_atk) { sources += [ "accessibility/native_view_accessibility_auralinux.cc", "accessibility/native_view_accessibility_auralinux.h", ... "widget/desktop_aura/desktop_window_tree_host_x11.cc", "widget/desktop_aura/desktop_window_tree_host_x11.h", ... } ... } ... } This means that if use_atk = false then we can't build views with linux desktop aura X11. This only works (by accident) because use_atk is defined as is_desktop_linux && use_x11. This was changed in https://codereview.chromium.org/2251673004 - use_x11 was changed to use_atk.
,
Sep 6 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ac7e772253dcde9e24c67e817a0cb568263c90f5 commit ac7e772253dcde9e24c67e817a0cb568263c90f5 Author: sunnyps <sunnyps@chromium.org> Date: Tue Sep 06 23:26:27 2016 Cleanup ui/views aura build configuration. ui/views would only build with x11 if use_atk was true. R=brettw@chromium.org BUG= 643412 Review-Url: https://codereview.chromium.org/2304763002 Cr-Commit-Position: refs/heads/master@{#416769} [modify] https://crrev.com/ac7e772253dcde9e24c67e817a0cb568263c90f5/ui/views/BUILD.gn
,
Sep 13 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by most...@opera.com
, Sep 1 2016I guess this should be split into two blocks: if (use_atk) { sources += "accessibility/native_view_accessibility_auralinux.cc", configs += [ "//build/config/linux/atk" ], } if (use_x11) { sources += <all the files with x11 in the name> }