print preview: printer icon is fuzzy in 2x (cuz it's a 1x image) |
|||||||||||||
Issue descriptionchrome://print/images/printer.png is a 24x24 PNG but needs to be a 48x48 PNG in 2x to be fresh and crispy. Try running chrome with --force-device-scale-factor=2 on a 1x screen and print something. We just need 2x assets for a few images in print preview.
,
Sep 21 2016
bettes@ is your go-to for image assets, although this might already be in progress of being resolved with Material updates.
,
Mar 29 2017
Replacing myself with hwi for interaction support
,
Aug 22 2017
malaykeshav@ could you please confirm that it's no longer relevant in material design?
,
Aug 22 2017
,
Aug 22 2017
dbeam@ we can't locate image you are referring to. Let us know if this is still an issue. If not I'll close the bug. thanks!
,
Aug 29 2017
Thanks! We need 2x assets added as we only have 1x https://cs.chromium.org/chromium/src/chrome/browser/resources/print_preview/images/ Assigning to thestig@ who has worked on this before
,
Aug 30 2017
These are very old but I managed to find the 2x exports in case they are missing.
,
Sep 15 2017
gotta get to 2000 commits somehow... (44 to go) screenshots: before + after (<-- crispier)
,
Sep 15 2017
The edges, they look... pointy. Careful now. Thanks for taking the bug.
,
Sep 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9108eeb3d74cff20b0cf85b28faad013952f7151 commit 9108eeb3d74cff20b0cf85b28faad013952f7151 Author: Dan Beam <dbeam@chromium.org> Date: Sat Sep 16 02:04:06 2017 Print Preview/HiDPI: add some 2x printer icons An aside: the UI rendering logic of print preview is kinda complex. In an ideal world, this would've been as easy as tweaking some CSS or HTML. Instead, JS had to get involved. Bummer. R=dpapad@chromium.org BUG= 643411 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I07a0236fc35027d184d3afeb9073a032cd14f8d8 Reviewed-on: https://chromium-review.googlesource.com/668114 Commit-Queue: Dan Beam (no longer on Chrome) <dbeam@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#502473} [modify] https://crrev.com/9108eeb3d74cff20b0cf85b28faad013952f7151/chrome/browser/browser_resources.grd [modify] https://crrev.com/9108eeb3d74cff20b0cf85b28faad013952f7151/chrome/browser/resources/print_preview/data/destination.js [rename] https://crrev.com/9108eeb3d74cff20b0cf85b28faad013952f7151/chrome/browser/resources/print_preview/images/1x/printer.png [rename] https://crrev.com/9108eeb3d74cff20b0cf85b28faad013952f7151/chrome/browser/resources/print_preview/images/1x/printer_shared.png [add] https://crrev.com/9108eeb3d74cff20b0cf85b28faad013952f7151/chrome/browser/resources/print_preview/images/2x/printer.png [add] https://crrev.com/9108eeb3d74cff20b0cf85b28faad013952f7151/chrome/browser/resources/print_preview/images/2x/printer_shared.png [modify] https://crrev.com/9108eeb3d74cff20b0cf85b28faad013952f7151/chrome/browser/resources/print_preview/search/destination_list_item.js [modify] https://crrev.com/9108eeb3d74cff20b0cf85b28faad013952f7151/chrome/browser/resources/print_preview/settings/destination_settings.js [modify] https://crrev.com/9108eeb3d74cff20b0cf85b28faad013952f7151/chrome/browser/ui/webui/print_preview/print_preview_ui.cc
,
Sep 19 2017
I'm going to mark this fixed but "Save as..." and others are likely still only 1x |
|||||||||||||
►
Sign in to add a comment |
|||||||||||||
Comment 1 by thestig@chromium.org
, Sep 21 2016